Skip to content

[Clang][Driver] Warn about -c/-S with -fsyntax-only #98607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 22, 2024
Merged

[Clang][Driver] Warn about -c/-S with -fsyntax-only #98607

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae43fc6
[Clang][Driver] Warn about `-c/-S` with `-fsyntax-only`
chestnykh Jul 12, 2024
607a433
[Clang][Driver] Refactor test
chestnykh Jul 15, 2024
1bc1ee7
[Clang][Driver] Remove extra newline from the test
chestnykh Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions clang/lib/Driver/ToolChains/Clang.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -794,10 +794,6 @@ static void addPGOAndCoverageFlags(const ToolChain &TC, Compilation &C,
Args.hasArg(options::OPT_coverage))
FProfileDir = Args.getLastArg(options::OPT_fprofile_dir);

// TODO: Don't claim -c/-S to warn about -fsyntax-only -c/-S, -E -c/-S,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. I left this in a07b135 to be cleaned up later but I forgot to remove this TODO.

// like we warn about -fsyntax-only -E.
(void)(Args.hasArg(options::OPT_c) || Args.hasArg(options::OPT_S));

// Put the .gcno and .gcda files (if needed) next to the primary output file,
// or fall back to a file in the current directory for `clang -c --coverage
// d/a.c` in the absence of -o.
Expand Down
9 changes: 9 additions & 0 deletions clang/test/Driver/warn-fsyntax-only-c-S.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// RUN: %clang -fsyntax-only -S %s 2>&1 | FileCheck %s --check-prefix=CHECK-ASM
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps just warn-fsyntax-only.c

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed

// RUN: %clang -fsyntax-only -c %s 2>&1 | FileCheck %s --check-prefix=CHECK-OBJ
// RUN: %clang -fsyntax-only -S -c %s 2>&1 | FileCheck %s --check-prefix=CHECK-BOTH

// CHECK-ASM: warning: argument unused during compilation: '-S' [-Wunused-command-line-argument]
// CHECK-OBJ: warning: argument unused during compilation: '-c' [-Wunused-command-line-argument]

// CHECK-BOTH: warning: argument unused during compilation: '-S' [-Wunused-command-line-argument]
// CHECK-NEXT: warning: argument unused during compilation: '-c' [-Wunused-command-line-argument]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHECK-NEXT is not used by any FileCheck command

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added -fsyntax-only -E case. -c -S i think is like duplication of -c and -S test cases

Loading