-
Notifications
You must be signed in to change notification settings - Fork 13.5k
[APFloat] Add APFloat::format #99088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ariel-Burton
wants to merge
2
commits into
llvm:main
Choose a base branch
from
Ariel-Burton:ariel/2024-07-16/apfloat-add-format
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,7 +18,9 @@ | |
#include "llvm/ADT/APInt.h" | ||
#include "llvm/ADT/ArrayRef.h" | ||
#include "llvm/ADT/FloatingPointMode.h" | ||
#include "llvm/ADT/SmallString.h" | ||
#include "llvm/Support/ErrorHandling.h" | ||
#include "llvm/Support/NativeFormatting.h" | ||
#include "llvm/Support/float128.h" | ||
#include <memory> | ||
|
||
|
@@ -557,6 +559,15 @@ class IEEEFloat final : public APFloatBase { | |
|
||
cmpResult compareAbsoluteValue(const IEEEFloat &) const; | ||
|
||
/// returns the exponent in the format's radix | ||
ExponentType getExponent() const; | ||
|
||
/// returns the significand | ||
APInt getSignificand() const; | ||
|
||
/// decompose to an integer and exponent to radix 2 | ||
bool decomposeToIntegerAndPowerOf2(APInt &, int &) const; | ||
|
||
private: | ||
/// \name Simple Queries | ||
/// @{ | ||
|
@@ -784,6 +795,8 @@ class DoubleAPFloat final : public APFloatBase { | |
|
||
bool getExactInverse(APFloat *inv) const; | ||
|
||
bool decomposeToIntegerAndPowerOf2(APInt &, int &) const; | ||
|
||
LLVM_READONLY | ||
int getExactLog2() const; | ||
LLVM_READONLY | ||
|
@@ -1381,6 +1394,20 @@ class APFloat : public APFloatBase { | |
toString(Str, FormatPrecision, FormatMaxPadding, TruncateZero)); | ||
} | ||
|
||
/// Decomposes the value to an integer and an exponent such that | ||
/// value = I * 2^exp | ||
/// returns true on success, false otherwise (e.g., NaN, Infinity) | ||
/// similar to the standard modf, but exponent does not | ||
/// have to have the same sign as the value. | ||
bool decomposeToIntegerAndPowerOf2(APInt &I, int &exp) const { | ||
APFLOAT_DISPATCH_ON_SEMANTICS(decomposeToIntegerAndPowerOf2(I, exp)); | ||
} | ||
|
||
SmallVectorImpl<char> & | ||
format(SmallVectorImpl<char> &strout, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why isn't this on raw_ostream, and using a raw small string? |
||
llvm::FloatStyle style = llvm::FloatStyle::Exponent, | ||
std::optional<size_t> precision = std::nullopt); | ||
|
||
void print(raw_ostream &) const; | ||
void dump() const; | ||
|
||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it is a limitation of APFloat, but this should return
std::optional<APInt, int>
.