[lldb][test] Fix simulator test for std::unique_ptr #99357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libcxx-simulators/unique_ptr/main.cpp uses __builtin_printf, that maps to printf on Windows. Include stdio.h to avoid linker errors on Windows. See https://lab.llvm.org/buildbot/#/builders/141/builds/853
|
@llvm/pr-subscribers-lldb Author: Leandro Lupori (luporl) Changeslibcxx-simulators/unique_ptr/main.cpp uses __builtin_printf, that Full diff: https://github.com/llvm/llvm-project/pull/99357.diff 1 Files Affected:
diff --git a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx-simulators/unique_ptr/main.cpp b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx-simulators/unique_ptr/main.cpp
index 08324e24f9cc4..a6bfaa3febebb 100644
--- a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx-simulators/unique_ptr/main.cpp
+++ b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx-simulators/unique_ptr/main.cpp
@@ -1,5 +1,7 @@
#include <libcxx-simulators-common/compressed_pair.h>
+#include <stdio.h>
+
namespace std {
namespace __lldb {
template <class _Tp> struct default_delete {
|
|
Test added in #98330. |
|
Merging to fix https://lab.llvm.org/buildbot/#/builders/141/builds/853, which has been broken for over 36 hours. |
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
Summary: libcxx-simulators/unique_ptr/main.cpp uses __builtin_printf, that maps to printf on Windows. Include stdio.h to avoid linker errors on Windows. See https://lab.llvm.org/buildbot/#/builders/141/builds/853 Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60250904
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libcxx-simulators/unique_ptr/main.cpp uses __builtin_printf, that
maps to printf on Windows. Include stdio.h to avoid linker errors
on Windows.
See https://lab.llvm.org/buildbot/#/builders/141/builds/853