[safestack] Various 32-bit Linux fixes #99455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When enabling 32-bit testing on Linux/i386 and Linux/sparc, many tests `FAIL`: - All Linux/i386 tests `FAIL` with ``` safestack CHECK failed: /vol/llvm/src/llvm-project/local/compiler-rt/lib/safestack/safestack.cpp:95 MAP_FAILED != addr ``` because the safestack `mmap` implementation doesn't work there. This patch adjusts it to match the `sanitizer_linux.cpp.c` one. - On 32-bit Linux/sparc, the `pthread*.c` tests `FAIL` because a `tid_t` (`uint64_t`) `tid` arg was passed to `syscall(SYS_tgkill)` while `tid` is actually a `pid_t` (`int`). Fixed by adding a cast. Tested on `x86_64-pc-linux-gnu` (32 and 64-bit) and `sparc64-unknown-linux-gnu` (32 and 64-bit).
vitalybuka
approved these changes
Jul 18, 2024
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
Summary: When enabling 32-bit testing on Linux/i386 and Linux/sparc, many tests `FAIL`: - All Linux/i386 tests `FAIL` with ``` safestack CHECK failed: /vol/llvm/src/llvm-project/local/compiler-rt/lib/safestack/safestack.cpp:95 MAP_FAILED != addr ``` because the safestack `mmap` implementation doesn't work there. This patch adjusts it to match the `sanitizer_linux.cpp.c` one. - On 32-bit Linux/sparc, the `pthread*.c` tests `FAIL` because a `tid_t` (`uint64_t`) `tid` arg was passed to `syscall(SYS_tgkill)` while `tid` is actually a `pid_t` (`int`). Fixed by adding a cast. Tested on `x86_64-pc-linux-gnu` (32 and 64-bit) and `sparc64-unknown-linux-gnu` (32 and 64-bit). Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60251393
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enabling 32-bit testing on Linux/i386 and Linux/sparc, many tests
FAIL:FAILwithsafestack CHECK failed: /vol/llvm/src/llvm-project/local/compiler-rt/lib/safestack/safestack.cpp:95 MAP_FAILED != addrbecause the safestackmmapimplementation doesn't work there. This patch adjusts it to match thesanitizer_linux.cpp.cone.pthread*.ctestsFAILbecause atid_t(uint64_t)tidarg was passed tosyscall(SYS_tgkill)whiletidis actually apid_t(int). Fixed by adding a cast.Tested on
x86_64-pc-linux-gnu(32 and 64-bit) andsparc64-unknown-linux-gnu(32 and 64-bit).