[Fortran/gfortran] Use -O0 for cshift_bounds_[34]. #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no support for `-fbounds-check` in Flang yet. There is a related feature request at https://github.com/orgs/llvm/projects/12?pane=issue&itemId=29048733 Until then, the optimizations may replace the Fortran runtime calls (which usually provide all the error checking) with inline sequences that do not check for errors to provide the fast code (e.g. llvm/llvm-project#119480). For the time being I would like to explicitly pass `-O0` to these tests.
|
The For now, if these are causing failures, you could disable the tests by adding them to |
|
Thank you, Tarun! I will disable the tests with a comment. |
tarunprabhu
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no support for
-fbounds-checkin Flang yet.There is a related feature request at Flang features to be implemented
Until then, the optimizations may replace the Fortran runtime calls
(which usually provide all the error checking) with inline sequences
that do not check for errors to provide the fast code
(e.g. llvm/llvm-project#119480).
For the time being I would like to disable these tests.