[SPEC2017] Use llvm_test_library for the wrf_netcdf target of 521.wrf_r so that to add dependencies required for compiletime measurements #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the wrf_netcdf target of 521.wrf_r Without this change, Fortran benchmarks of SPEC2017 fail to build. Steps to reproduce: $ cmake -B builddir \ -DCMAKE_C_COMPILER=clang \ -DCMAKE_CXX_COMPILER=clang++ \ -DCMAKE_Fortran_COMPILER=flang \ -G Ninja \ -C cmake/caches/O3.cmake \ -DTEST_SUITE_SPEC2017_ROOT=path/to/cpu2017-v1.1.5 \ -DTEST_SUITE_RUN_TYPE=ref \ -DTEST_SUITE_FORTRAN=ON \ -DCMAKE_C_FLAGS=-Wno-implicit-int \ -DCMAKE_CXX_FLAGS=-Wno-implicit-int $ cmake --build builddir/ [0/2] Re-checking globbed directories... [1932/35275] Building C object External/SPEC/CFP2017rate/521.wrf_r/CMakeFiles/wrf_netcdf.dir/__/__/cpu2017-v1.1.5/benchspec/CPU/521.wrf_r/src/netcdf/attr.c.o FAILED: ... /bin/sh: 1: builddir/tools/timeit: not found
lukel97
approved these changes
Apr 28, 2025
Thanks. |
lukel97
approved these changes
May 14, 2025
SixWeining
changed the title
SixWeining
added a commit
that referenced
this pull request
May 14, 2025
…df target of 527.cam4_r Similar to #238.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, Fortran benchmarks of SPEC2017 fail to build. Steps to reproduce: