Skip to content

[Fortran/gfortran] Enable tests that now pass #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2025
Merged

[Fortran/gfortran] Enable tests that now pass #245

merged 1 commit into from
May 20, 2025

Conversation

tarunprabhu
Copy link
Contributor

@tarunprabhu tarunprabhu commented May 14, 2025 •
edited
Loading

A number of tests now pass since several bugs in flang have been fixed and other features have been implemented.

@tarunprabhu tarunprabhu marked this pull request as ready for review May 14, 2025 17:00
@AlexisPerry
Copy link

I get the following results:

llvm-lit -v -o report.json .
-- Testing: 6942 tests, 256 workers --
...
Testing Time: 2358.15s

Total Discovered Tests: 6942
  Passed: 6942 (100.00%)

tblah
tblah approved these changes May 15, 2025
View reviewed changes
Copy link
Contributor

@tblah tblah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

jeanPerier
jeanPerier approved these changes May 15, 2025
View reviewed changes
Copy link
Contributor

@jeanPerier jeanPerier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works for me on X86-64. Thanks!

Total Discovered Tests: 6943
Passed: 6943 (100.00%)

ylzsx
ylzsx approved these changes May 19, 2025
View reviewed changes
Copy link
Contributor

@ylzsx ylzsx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. With the parameter -O3, it works well on a LoongArch machine.

kkwli
kkwli approved these changes May 19, 2025
View reviewed changes
Copy link
Contributor

@kkwli kkwli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for powerpc64le-unknown-linux-gnu and powerpc64-ibm-aix7.2.0.0. Thanks.

@tarunprabhu
[Fortran/gfortran] Enable tests that now pass
9a08114 
A number of tests now pass since several bugs in flang have been fixed and
othe features have been implemented.
@tarunprabhu tarunprabhu force-pushed the enable-passing-tests branch from 442f330 to 9a08114 Compare May 20, 2025 13:35
@tarunprabhu
Copy link
Contributor Author

Thanks @AlexisPerry, @tblah, @jeanPerier, @ylzsx, @kkwli for testing this.

@tarunprabhu tarunprabhu merged commit ce7b42e into llvm:main May 20, 2025
1 check passed
@tarunprabhu tarunprabhu deleted the enable-passing-tests branch May 20, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tblah tblah tblah approved these changes

@kkwli kkwli kkwli approved these changes

@jeanPerier jeanPerier jeanPerier approved these changes

@ylzsx ylzsx ylzsx approved these changes

@kiranchandramohan kiranchandramohan Awaiting requested review from kiranchandramohan

@AlexisPerry AlexisPerry Awaiting requested review from AlexisPerry

@luporl luporl Awaiting requested review from luporl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tarunprabhu @AlexisPerry @tblah @kkwli @jeanPerier @ylzsx