Skip to content
This repository was archived by the owner on Apr 29, 2019. It is now read-only.

Conversation

VoronoyAlexandr
Copy link
Contributor

@VoronoyAlexandr VoronoyAlexandr commented Nov 2, 2018

Description

Added argument to PHPDoc annotation @method setRowClickCallback(string $value)

Fixed Issues

#125 Clean Up Magento/ImportExport/Block/Adminhtml/Export/Filter

Manual testing scenarios (*)

Run ./vendor/bin/phpstan analyse -l 0 app/code/Magento/ImportExport/Block/Adminhtml/Export/Filter.php

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Nov 2, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

@VoronoyAlexandr thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@dmanners
Copy link
Contributor

dmanners commented Nov 9, 2018

Hi @VoronoyAlexandr thanks for this pull request.

Could you check the static tests.

Magento\Test\Php\LiveCodeTest::testCodeStyle
PHP Code Sniffer detected 2 violation(s): 

FILE: /var/www/html/app/code/Magento/Backend/Block/Widget/Grid.php
----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
 152 | ERROR | [x] Missing short description
 153 | ERROR | [x] There must be exactly one blank line before tags
 712 | ERROR | [x] There must be exactly one blank line between lines
----------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Thanks

@VoronoyAlexandr
Copy link
Contributor Author

Good day @dmanners . Done with this errors.

Copy link
Contributor

@dmanners dmanners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let me process this PR for you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants