This repository was archived by the owner on Nov 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Improve Cloud Starter - New Relic config instructions #6809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for New Relic reporting - Add prerequisites for credentials and role access required to add the license key to an environment - Link to alternative instructions for getting the New Relic license key from New Relic account, and adding the license key from the Magento Admin - Added separate H3 headings for Configure Starter for New Relic and Remove license key from Starter to make content easier to scan
meker12
commented
Mar 9, 2020
hguthrie
approved these changes
Mar 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In some ways, adding link definitions at the bottom makes it much easier to read the underlying markdown, so that is helpful. Unfortunately, this page seems like there is an inordinate amount of links. It might help to alphabetize them. Looked like there were numbers to begin with and then that stopped. When you want to find a link in the long list, now it takes a little more time to read through.
michaelcasey316
approved these changes
Mar 10, 2020
Co-Authored-By: hguthrie <[email protected]>
Co-Authored-By: hguthrie <[email protected]>
Co-Authored-By: hguthrie <[email protected]>
- Changed all anchor reference links to inline links - Alphabetized link reference list - Removed numeric references
running tests |
1 similar comment
running tests |
running tests |
Hi @meker12, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
2.3.x
Magento 2.3 related changes
Internal Dev
Differentiates work between community and Magento staff
Technical
Updates to the code or processes that alter the technical content of the doc
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per user feedback (PR #6708):
Improve instructions for configuring Starter projects for New Relic reporting:
the license key to an environment
key from New Relic account, and adding the license key from the Magento
Admin
Remove license key from Starter to make content easier to scan
Purpose of this pull request
Per user feedback (PR #6708)
Improve instructions for configuring Starter projects for New Relic reporting
the license key to an environment
key from New Relic account, and adding the license key from the Magento
Admin
Remove license key from Starter to make content easier to scan
Affected DevDocs pages
https://devdocs.magento.com/cloud/project/new-relic.html
whatsnew
Improved the instructions to configure Cloud Starter projects to use New Relic to add alternative instructions for users who have access to New Relic and the Magento Admin for a site, but do not have access to configure environment variables through the Magento Cloud project. See Configure New Relic for Starter environments.