Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Added new option to static-content:deploy command #8765

Merged
merged 5 commits into from
Mar 24, 2021

Conversation

chandru-199
Copy link
Contributor

@chandru-199 chandru-199 commented Mar 3, 2021

Purpose of this pull request

This pull request (PR) - Adding information about new option available in static-content:deploy command from 2.4.2 version as per the PR.

Affected DevDocs pages

@hostep
Copy link
Contributor

hostep commented Mar 3, 2021

This will fix #8561 btw, thank you @chandru-199! 🙂

<tr>
<td>--no-parent</td>
<td>
<p>This option will be available from 2.4.2 version.It provides ability to deploy the only specific theme(s) for multiple locales, so it will improve build phase of deployment for the those who use single theme with different locales.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Only one thing: since 2.4.2 has been released, I would say "This option is available from 2.4.2"

@keharper
Copy link
Contributor

keharper commented Mar 5, 2021

@chandru-199 Can you think of a good example showing this new flag? If yes, please add it the examples section.

@hostep
Copy link
Contributor

hostep commented Mar 5, 2021

I think we should try to encourage this new flag somehow, since it has a very big performance impact and makes the SCD command run many times faster.

@dobooth
Copy link
Contributor

dobooth commented Mar 16, 2021

@chandru-199 Looks like a new example would be good here.

@chandru-199
Copy link
Contributor Author

Hey @dobooth @aleron75. Sorry for the delay in progress of this PR.

Currently I don't have ready to go 2.4.2 setup. I need some time for it. I will add once it's ready.

@hostep
Copy link
Contributor

hostep commented Mar 16, 2021

@dobooth: here's what I remember from the past, maybe it helps:

  • The --no-parent flag behaves like how Magento 2.0.x and 2.1.x compiled static assets (but you didn't need to specify a flag, this was default behavior back then)
  • For some reason, in Magento 2.2.x they rewrote the SCD process and for some unknown reason the parent themes of the theme you tried to deploy were also always deployed even though that was not needed
  • Instead of reverting back to the behavior of Magento 2.1.x, it was decided (out of caution) to provide a new flag to revert back to this old behavior, so that people have to explicitly choose to use this flag and aren't forced to use it in case they have some obscure edge case that needs the parent themes to be deployed as well

In my opinion, 99% of the people should be using this new --no-parent flag on all their projects, because it significantly increases the speed of the SCD process and should not cause regressions.

Hope this is helpful in figuring out how to communicate this properly 🙂

<tr>
<td>--no-parent</td>
<td>
<p>This option provides the ability to deploy only the specific themes for multiple locales. It improves the build phase of deployment for the those who use a single theme with different locales.</p>
Copy link
Contributor

@hostep hostep Mar 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say something like:

Do not generate files for the parent themes of the current theme. It is strongly recommended to use this flag if you don't explicitly use the parent theme of the current theme you are trying to deploy in your shop. Using this flag will significantly increase the speed of this process.

This flag became available in Magento 2.4.2

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Thanks for that.

@dobooth dobooth added the 2.4.x Magento 2.4.x related changes label Mar 17, 2021
@dobooth dobooth added the Technical Updates to the code or processes that alter the technical content of the doc label Mar 17, 2021
@dobooth
Copy link
Contributor

dobooth commented Mar 24, 2021

@magento import code to magento-devdocs/devdocs.

@magento-engcom-team
Copy link

@dobooth the branch with code successfully imported intomagento-devdocs/devdocs repository. Branch name: imported-magento-devdocs-8765.

@magento-cicd2 magento-cicd2 merged commit 70a1474 into magento:master Mar 24, 2021
@ghost
Copy link

ghost commented Mar 24, 2021

Hi @chandru-199, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@chandru-199
Copy link
Contributor Author

@dobooth : Please add partner:ziffity label to this PR.

@chandru-199
Copy link
Contributor Author

@ajithkumar-maragathavel : Could you Please add partner:ziffity label to this PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.4.x Magento 2.4.x related changes Partner: Ziffity partners-contribution PR created by Magento partner Progress: done Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants