#49: LocalizedException SHOULD only be thrown in View #53
Conversation
larsroettig
changed the title
| @@ -195,6 +195,10 @@ | |||
| <severity>7</severity> | |||
| <type>warning</type> | |||
| </rule> | |||
| <rule ref="Magento.Exceptions.LocalizedThrow"> | |||
| <severity>7</severity> | |||
There was a problem hiding this comment.
Please change the severity to 8. This rule looks like:
Magento specific code issue.
There was a problem hiding this comment.
Sorry for nit-picking, but could you please add rules in alphabetical order? So they will be ordered by severity then by name.
| use PHP_CodeSniffer\Files\File; | ||
|
|
||
| /** | ||
| * Detects possible direct throws of Exceptions. |
| /** | ||
| * String representation of warning. | ||
| */ | ||
| protected $warningMessage = 'LocalizedException SHOULD only be thrown in the Presentation layer.'; |
There was a problem hiding this comment.
It looks like tech guidelines must be updated to allow LocalizedException in Service Layer as well. See #5.17 in https://devdocs.magento.com/guides/v2.3/coding-standards/technical-guidelines.html
Please do not merge this PR until tech guidelines are updated.
|
@paliarush can you give me feedback than i change the implementation |
|
Close because of Impelementation does not solve it able with the new requirements with tokens See: |
…-coding-standard-254 [Imported] Ignore PHPUnit results cache file
see: #49