-
Notifications
You must be signed in to change notification settings - Fork 27
Update composer dependencies and unit tests #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hi @drpayyne, Could you redirect it to the develop branch You have a failed test build because PHP 7.2 is out of support. Could you update the PHP version used for the build? We need to run build with PHP 7.3 To properly test these changes, we need to create a temporary PR into magento2-infrastructure and update composer.json dependency to use your branch as a source. See an example |
Hi @fascinosum, I've updated PHP in composer and the GitHub workflow config file. Unfortunately I don't have access to the infra repo you have linked. I am part of a partner org (EY), so I'm not sure if that repo is available to partners. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @drpayyne
Thank you for your contribution.
I fixed the infrastructure and code styling problems.
Changes are approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @drpayyne,
Could you review and fix the warnings when running unit tests?
You can find them here:
https://github.com/magento/magento-semver/pull/61/checks
Sure @ihor-sviziev, I will fix those today. |
composer.json
Outdated
}, | ||
"require-dev": { | ||
"phpunit/phpunit": "^6.5.0", | ||
"phpunit/phpunit": "9.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we allow installing 9.3.x?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @ihor-sviziev.
I changed it temporary to have some checks.
Now, I fixed all changes and squashed commits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update recent changes from the develop branch
- updated composer dependencies - fixed build yaml file
1d1d12a
to
b352612
Compare
This pull request (PR) closed because has been created from wrong branch (master instead of develop) and has a lot of merge-conflicts. |
13.0.0-beta6 version
Description
^7.3||^8.0
^9.5
^4.10
^0.5
7.3
in.github/workflows/php.yml
Fixed Issues
Contribution checklist (*)