Skip to content

MQE-999: Replace all explicit print or echo statements with logging #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2018
Merged

MQE-999: Replace all explicit print or echo statements with logging #137

merged 1 commit into from
Jun 1, 2018

Conversation

imeron2433
Copy link
Contributor

  • add LogginUtil and monolog
  • remove expliclit echo/print statements
  • update tests
  • update mftf exceptions to include log statments

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@imeron2433
MQE-999: Replace all explicit print or echo statements with logging
db1ce7b 
- add LogginUtil and monolog
- remove expliclit echo/print statements
- update tests
- update mftf exceptions to include log statments
@magento-cicd2
Copy link

magento-cicd2 commented Jun 1, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 58.268% when pulling db1ce7b on MQE-999 into 57ad442 on develop.

1 similar comment
@coveralls
Copy link

coveralls commented Jun 1, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.04%) to 58.268% when pulling db1ce7b on MQE-999 into 57ad442 on develop.

@imeron2433 imeron2433 merged commit c62b9d2 into develop Jun 1, 2018
@imeron2433 imeron2433 deleted the MQE-999 branch June 1, 2018 20:50
magento-devops-reposync-svc pushed a commit that referenced this pull request Dec 7, 2021
@okolesnyk
Merge pull request #137 from magento-commerce/MQE-3122
d0216ab 
MQE-3122: Logging of failed test is not working when test fails in `after` section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imeron2433 @magento-cicd2 @coveralls