Skip to content

MQE-1031: Empty files are flagged during generation or dealt with gracefully #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 9, 2018
Merged

MQE-1031: Empty files are flagged during generation or dealt with gracefully #139

merged 5 commits into from
Jun 9, 2018

Conversation

aljcalandra
Copy link
Contributor

@aljcalandra aljcalandra commented Jun 7, 2018 •
edited
Loading

Description

Empty XML files will no longer prevent tests from generating. An error will be logged in these cases.

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@aljcalandra
MQE-1031: Empty files are flagged during generation or dealt with
400d5e5 
gracefully

 - Added check for empty file
@aljcalandra
MQE-1031: Empty files are flagged during generation or dealt with
3f4add8 
gracefully

 - Merged Develop into branch
@aljcalandra
MQE-1031: Empty files are flagged during generation or dealt with
03f0a65 
gracefully

- Added windows compatibility for checks
- Fixed static check in Filesystem
@aljcalandra
MQE-1031: Empty files are flagged during generation or dealt with
c7200d3 
gracefully

- Changed method name as requested
@magento-cicd2
Copy link

magento-cicd2 commented Jun 7, 2018 •
edited
Loading

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@coveralls
Copy link

coveralls commented Jun 9, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 58.736% when pulling 261ea1d on MQE-1031 into 22965f6 on develop.

@aljcalandra aljcalandra merged commit 2f70705 into develop Jun 9, 2018
@aljcalandra aljcalandra deleted the MQE-1031 branch June 9, 2018 15:44
magento-devops-reposync-svc pushed a commit that referenced this pull request Dec 10, 2021
@jilu1
Merge pull request #139 from magento-commerce/imported-magento-arctic…
a00dcb5 
…foxes-magento2-functional-testing-framework-875

[Imported] Fix encoding issue when secret key contains plus sign
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aljcalandra @magento-cicd2 @coveralls