Skip to content

MQE-1117: dontSeeJsError does not catch JS errors #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 28, 2018
Merged

MQE-1117: dontSeeJsError does not catch JS errors #223

merged 8 commits into from
Sep 28, 2018

Conversation

jilu1
Copy link
Contributor

@jilu1 jilu1 commented Sep 13, 2018

Description

MQE-1117: dontSeeJsError does not catch JS errors

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 57.151% when pulling a10efc5 on MQE-1117 into 31ddcc8 on develop.

@coveralls
Copy link

coveralls commented Sep 13, 2018

Coverage Status

Coverage remained the same at 57.516% when pulling 95e0b23 on MQE-1117 into 94afc74 on develop.

- addressed static test failures
@jilu1 jilu1 changed the title [MFTF 2.3.7] Bug Fix MQE-1117 [MFTF 2.3.7] Bug Fix MQE-1117: dontSeeJsError does not catch JS errors Sep 13, 2018
@jilu1 jilu1 changed the title [MFTF 2.3.7] Bug Fix MQE-1117: dontSeeJsError does not catch JS errors [2.3.7] Bug Fix MQE-1117: dontSeeJsError does not catch JS errors Sep 13, 2018
@KevinBKozan KevinBKozan changed the title [2.3.7] Bug Fix MQE-1117: dontSeeJsError does not catch JS errors MQE-1117: dontSeeJsError does not catch JS errors Sep 14, 2018
@KevinBKozan KevinBKozan changed the title MQE-1117: dontSeeJsError does not catch JS errors Bug Fix MQE-1117: dontSeeJsError does not catch JS errors Sep 14, 2018
@KevinBKozan KevinBKozan changed the title Bug Fix MQE-1117: dontSeeJsError does not catch JS errors MQE-1117: dontSeeJsError does not catch JS errors Sep 14, 2018
Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spoke in person, we should clear the cache of JS errors on a per-page basis; the cache needs some context, otherwise an error could occur in the very beggining of the test, and calling dontSeeJSError at the very end would cause a failure.

- changed to only check js errors in current page
KevinBKozan
KevinBKozan previously approved these changes Sep 26, 2018
Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, feature works as expected.
Make sure that:

  1. Devdocs points out that dontseejserror is per-page
  2. Fix static errors

# Conflicts:
#	src/Magento/FunctionalTestingFramework/Extension/ErrorLogger.php
KevinBKozan
KevinBKozan previously approved these changes Sep 27, 2018
@jilu1 jilu1 merged commit 26487bc into develop Sep 28, 2018
@jilu1 jilu1 deleted the MQE-1117 branch September 28, 2018 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants