-
Notifications
You must be signed in to change notification settings - Fork 131
MQE-1117: dontSeeJsError does not catch JS errors #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- addressed static test failures
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spoke in person, we should clear the cache of JS errors on a per-page basis; the cache needs some context, otherwise an error could occur in the very beggining of the test, and calling dontSeeJSError
at the very end would cause a failure.
- changed to only check js errors in current page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me, feature works as expected.
Make sure that:
- Devdocs points out that
dontseejserror
is per-page - Fix static errors
# Conflicts: # src/Magento/FunctionalTestingFramework/Extension/ErrorLogger.php
- fix static test issue
- fix static test issue
- fix static test issue
- fix static test issue
Description
MQE-1117: dontSeeJsError does not catch JS errors
Contribution checklist