Skip to content

MQE-1142: Use timeout value when waitForLoadingMaskToDisappear #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2018
Merged

MQE-1142: Use timeout value when waitForLoadingMaskToDisappear #225

merged 1 commit into from
Sep 18, 2018

Conversation

jilu1
Copy link
Contributor

@jilu1 jilu1 commented Sep 13, 2018

Description

MQE-1142: Use timeout value when waitForLoadingMaskToDisappear

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

coveralls commented Sep 13, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.008%) to 57.151% when pulling f267432 on MQE-1142 into 31ddcc8 on develop.

@KevinBKozan KevinBKozan changed the title [2.3.7] Bug fix MQE-1142: Use timeout value when waitForLoadingMaskToDisappear MQE-1142: Use timeout value when waitForLoadingMaskToDisappear Sep 14, 2018
KevinBKozan
KevinBKozan approved these changes Sep 14, 2018
View reviewed changes
Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete, confirmed this works for passing down timeout in execution.

@jilu1 jilu1 merged commit c4d3307 into develop Sep 18, 2018
@jilu1 jilu1 deleted the MQE-1142 branch November 6, 2018 17:26
magento-devops-reposync-svc pushed a commit that referenced this pull request Oct 20, 2022
@KevinBKozan
Merge pull request #225 from magento-commerce/ACQE-3464
588649e 
ACQE-4122: fixed an issue in test generation with config parallel by …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinBKozan KevinBKozan KevinBKozan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jilu1 @coveralls @KevinBKozan