Skip to content

MQE-1254: MFTF with Firefox fails due to getLog call #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2018
Merged

Conversation

aljcalandra
Copy link
Contributor

  • Added check to ascertain browser is among the available log types

Prevents a call to getLog for a type of log that may not exist

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

- Added check to ascertain browser is among the available log types
Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@coveralls
Copy link

Coverage Status

Coverage remained the same at 57.398% when pulling ea9693d on MQE-1254 into 66b6ecd on develop.

@aljcalandra aljcalandra merged commit 67af7e0 into develop Sep 20, 2018
@aljcalandra aljcalandra deleted the MQE-1254 branch September 20, 2018 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants