Skip to content

MQE-1150: Test generation fails for arguments containing hyphen character #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 25, 2018
Merged

MQE-1150: Test generation fails for arguments containing hyphen character #231

merged 4 commits into from
Sep 25, 2018

Conversation

KevinBKozan
Copy link
Contributor

Description

  • Made regex more flexible, should accept any character except for ones that break the pattern.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@KevinBKozan
MQE-1150: Test generation fails for arguments containing hyphen chara…
12c098a 
…cter

- Made regex more flexible, should accept any character except for ones that break the pattern.
@KevinBKozan
MQE-1142: Use timeout value when waitForLoadingMaskToDisappear
bc0e154 
- Added default value for $timeout attribute (causing issues with CE tests)
@KevinBKozan
Merge branch 'MQE-1142-Fix' into MQE-1150
995c78f
jilu1
jilu1 previously requested changes Sep 19, 2018
View reviewed changes
Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. Can you add verification test for this use case?

@coveralls
Copy link

coveralls commented Sep 19, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 57.398% when pulling 18a9e57 on MQE-1150 into 66b6ecd on develop.

@KevinBKozan
Copy link
Contributor Author

@jilu1 added verification test for use case.

@aljcalandra aljcalandra self-requested a review September 21, 2018 18:01
@KevinBKozan KevinBKozan dismissed jilu1’s stale review September 25, 2018 13:26

Already reviewed by aljcalandra.

@KevinBKozan KevinBKozan merged commit 56440ef into develop Sep 25, 2018
@KevinBKozan KevinBKozan deleted the MQE-1150 branch September 25, 2018 13:27
magento-devops-reposync-svc pushed a commit that referenced this pull request Oct 18, 2022
@jilu1
Merge pull request #231 from magento-gl/master
db1b01e 
Master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aljcalandra aljcalandra aljcalandra approved these changes

@jilu1 jilu1 jilu1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KevinBKozan @coveralls @jilu1 @aljcalandra