MQE-1173: [Dev experience] Error on test generation without reference on file #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on file - Added error messaging at Action level - Extended range of errors caught at Test level - Added unit tests for Exception catching for TestGenerator and ActionMergeUtil
… on file - Removed unused use cases
… on file - Removed use
KevinBKozan
suggested changes
Sep 21, 2018
There was a problem hiding this comment.
Changes look good, but original ticket concern was about declaring an element with parameterized=true and no parameters in the selector.
This still causes a warning on ActionObject line 711, we should check if empty($varMatches[0]) and throw an exception there use your exception catching here.
… on file - Added setting parameter list to [] in case of no parameters
… on file - Moved count out of matching method
KevinBKozan
reviewed
Sep 24, 2018
| ); | ||
| } elseif (count($matches) == 0) { | ||
| throw new TestReferenceException( | ||
| "Parameter Resolution Failed: No parameter matches found for reference " . |
There was a problem hiding this comment.
Minor picky-ness, exception message isn't quite clear. Should be more like
Parameter Resolution Failed: No parameters found in parameterized element with selector "selector"
From our standpoint the exception message makes sense, but we should probably keep this more specific.
… on file - Made requested changes - Updated unit tests to be a bit more descriptive
KevinBKozan
approved these changes
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give better error messaging when parsing and referencing steps.
Return error message with test regardless of type of exception
Contribution checklist