MQE-910: [GitHub] The property of the parent element is used first when making a request #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
… when making a request
jilu1
force-pushed
the
MQE-910-develop
branch
from
b153bf4 to
593e531
Compare
KevinBKozan
suggested changes
Nov 27, 2018
| $paramEntityParent = ""; | ||
| $matchedParent = []; | ||
| $dataItem = $matchedParams[1][$paramKey]; | ||
| preg_match_all("/(.+?)\./", $dataItem, $matchedParent); |
There was a problem hiding this comment.
Add comment:
Try to find "type." in "type.field"
| $dataItem = $matchedParams[1][$paramKey]; | ||
| preg_match_all("/(.+?)\./", $dataItem, $matchedParent); | ||
|
|
||
| if (!empty($matchedParent) && !empty($matchedParent[0])) { |
There was a problem hiding this comment.
Add comment:
Assign entity "type" for filtering, remove "type." from parameter
… when making a request - added some comments
KevinBKozan
approved these changes
Nov 27, 2018
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Dec 6, 2022
3.12.0 RC Checklist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed Issues (if relevant)
Contribution checklist