Skip to content

Reduce cyclomatic complexity in Problem Methods #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 22, 2019
Merged

Reduce cyclomatic complexity in Problem Methods #318

merged 4 commits into from
Mar 22, 2019

Conversation

sergeynezbritskiy
Copy link
Contributor

@sergeynezbritskiy sergeynezbritskiy commented Mar 16, 2019

Description

Reduce the Cyclomatic Complexity to <=10 in the following methods:

  • OperationDefinitionObjectHandler::initDataDefinitions()
  • OperationDataArrayResolver::resolveOperationDataArray()

Fixed Issues (if relevant)

  1. Reduce Cyclomatic Complexity in Problem Methods #59: Reduce cyclomatic complexity in Problem Methods
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@magento-cicd2
Copy link

magento-cicd2 commented Mar 16, 2019

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Mar 16, 2019

Coverage Status

Coverage decreased (-0.3%) to 56.793% when pulling 6ddc2b6 on sergeynezbritskiy:issue-59-reduce-cyclomatic-complexity into 4fc3430 on magento:develop.

@KevinBKozan
Copy link
Contributor

@sergeynezbritskiy Thank you for your contribution! We will be reviewing your changes, and will keep you updated on progress.

Also, see above, some static checks failed (you can run them locally via bin/static-checks)

@KevinBKozan KevinBKozan merged commit 24723b5 into magento:develop Mar 22, 2019
magento-devops-reposync-svc pushed a commit that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants