Skip to content

Added Nginx specific settings to getting started doc #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2019

Conversation

vovsky
Copy link
Contributor

@vovsky vovsky commented Apr 17, 2019

Description

Added Nginx specific settings to Getting Started doc. I was missing this info when I started to contribute to MFTF.

@magento-cicd2
Copy link

magento-cicd2 commented Apr 17, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team magento-engcom-team added partners-contribution Pull Request is created by Magento Partner Partner: Atwix labels Apr 17, 2019
@coveralls
Copy link

coveralls commented Apr 17, 2019

Coverage Status

Coverage remained the same at 56.991% when pulling 304b7ea on vovsky:getting-started-nginx-config into c9dd418 on magento:develop.

@KevinBKozan
Copy link
Contributor

@vovsky, thank you for your contribution! I created an internal ticket to track progress on this PR, and we'll keep you updated on progress as we make it.

Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledged Partner: Atwix partners-contribution Pull Request is created by Magento Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants