Skip to content

MQE-1457 #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 19, 2019
Merged

MQE-1457 #334

merged 3 commits into from
Apr 19, 2019

Conversation

ivy00johns
Copy link
Contributor

Description

  • Removing incorrect "timeout" code.
  • Adding a note regarding the correct variable to use.

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#MQE-1457: [PWA] The "waitForPwaElementVisible" action does not reference the 'timeout' value set

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@ivy00johns
magento-pangolin/magento2-functional-testing-framework#MQE-1457: [PWA…
a070a32 
…] The "waitForPwaElementVisible" action does not reference the 'timeout' value set

- Adding a note regarding the correct variable to set the timeout value.
@coveralls
Copy link

coveralls commented Apr 17, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-1.5%) to 55.443% when pulling bd990cc on MQE-1457 into 9b5d79c on develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.5%) to 55.443% when pulling a070a32 on MQE-1457 into 9b5d79c on develop.

jilu1
jilu1 suggested changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my inline comment

ivy00johns and others added 2 commits April 18, 2019 13:38
@ivy00johns
magento-pangolin/magento2-functional-testing-framework#MQE-1457: [PWA…
2c84791 
…] The "waitForPwaElementVisible" action does not reference the 'timeout' value set

- Reverting change.
@ivy00johns
Merge branch 'develop' into MQE-1457
bd990cc
jilu1
jilu1 approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ivy00johns ivy00johns merged commit 24ac1d9 into develop Apr 19, 2019
@ivy00johns ivy00johns deleted the MQE-1457 branch June 4, 2019 19:26
magento-devops-reposync-svc pushed a commit that referenced this pull request Sep 6, 2023
@KevinBKozan
Merge pull request #334 from magento-gl/AC-9335-cleaned
b8d908f 
Ac 9335 cleaned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jilu1 jilu1 jilu1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivy00johns @coveralls @jilu1