Skip to content

MQE-1706: Create training plan for core engineers and community #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Oct 8, 2019
Merged

MQE-1706: Create training plan for core engineers and community #475

merged 18 commits into from
Oct 8, 2019

Conversation

tomreece
Copy link
Contributor

@tomreece tomreece commented Oct 2, 2019

In progress PR for our documentation work.

https://jira.corp.magento.com/browse/MQE-1706

@tomreece tomreece changed the title MQE-1706 MQE-1706: Create training plan for core engineers and community Oct 2, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 53.589% when pulling 090fb6e on MQE-1706 into 6675ee5 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 53.589% when pulling 090fb6e on MQE-1706 into 6675ee5 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 53.589% when pulling 090fb6e on MQE-1706 into 6675ee5 on master.

@coveralls
Copy link

coveralls commented Oct 2, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.7%) to 52.561% when pulling 9f9a627 on MQE-1706 into 6675ee5 on master.

@soumyau soumyau self-requested a review October 2, 2019 20:56
tomreece
tomreece commented Oct 3, 2019
View reviewed changes
jilu1
jilu1 reviewed Oct 3, 2019
View reviewed changes
soumyau
soumyau reviewed Oct 3, 2019
View reviewed changes
Copy link
Contributor

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed comments for using-suites.md.

@jilu1
Copy link
Contributor

jilu1 commented Oct 7, 2019

No pending issue from my side. Looks good

dobooth
dobooth suggested changes Oct 7, 2019
View reviewed changes
@dobooth dobooth added the DOC label Oct 7, 2019
@tomreece
Copy link
Contributor Author

tomreece commented Oct 7, 2019 •
edited
Loading

Everyone has signed off on it, let's merge it...
Since it's to the master branch, only Kevin or Alex can do this.

@KevinBKozan
Copy link
Contributor

@soumyau still has changes requested on this, merging is blocked currently.

@KevinBKozan KevinBKozan requested a review from soumyau October 8, 2019 13:28
@KevinBKozan KevinBKozan merged commit ef8ae84 into master Oct 8, 2019
@dobooth dobooth deleted the MQE-1706 branch October 29, 2019 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jilu1 jilu1 jilu1 left review comments

@KevinBKozan KevinBKozan KevinBKozan left review comments

@soumyau soumyau soumyau approved these changes

@dobooth dobooth dobooth approved these changes

Assignees
No one assigned
Labels
DOC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tomreece @coveralls @jilu1 @KevinBKozan @soumyau @dobooth