Skip to content

magento/magento2-functional-testing-framework#56: Add "block" type to… #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2018

Conversation

sdzhepa
Copy link
Contributor

@sdzhepa sdzhepa commented Mar 23, 2018

Description

Was added "block" as possible value for SectionObject type

Fixed Issues (if relevant)

  1. Add "block" type to list of existing section element types #56: Add "block" type to list of existing section element types

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@magento-cicd2
Copy link

magento-cicd2 commented Mar 23, 2018

CLA assistant check
All committers have signed the CLA.

@magento magento deleted a comment from coveralls Mar 23, 2018
@magento magento deleted a comment from coveralls Mar 23, 2018
@magento magento deleted a comment from coveralls Mar 23, 2018
@okolesnyk
Copy link
Member

@sdzhepa Thank you for your contribution. Please sign Contributor License Agreement so we will be able to proceed with PullRequest.

@sdzhepa
Copy link
Contributor Author

sdzhepa commented Mar 23, 2018

@okolesnyk Done

@okolesnyk okolesnyk merged commit 8e7d4d8 into magento:CD-develop Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants