MQE-2040: Unable to run suites from standalone MFTF #655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jilu1
reviewed
Mar 27, 2020
| $groupPath = PROJECT_ROOT . '/src/Magento/FunctionalTestingFramework/Group'; | ||
| foreach (glob($groupPath. '/*.php') as $suitePhpFile) { | ||
| include_once $suitePhpFile; | ||
| } |
There was a problem hiding this comment.
The Group is in MFTF namespace. I am not sure why we need to require it in particular. Do you see the tests file being generated for the suite?
jilu1
suggested changes
Mar 27, 2020
Included suite php files to standalone_bootstrap
Updated $ROOT_SUITE dir path based on installation type
added getRootSuiteDirPath
fixed static check
jilu1
reviewed
Mar 31, 2020
| @@ -28,7 +29,7 @@ public function get($filename, $scope) | |||
| { | |||
| // First pick up the root level test suite dir | |||
| $paths = glob( | |||
| FilePathFormatter::format(TESTS_BP) . self::ROOT_SUITE_DIR | |||
| FilePathFormatter::format($this->getRootSuiteDirPath()) . self::ROOT_SUITE_DIR | |||
There was a problem hiding this comment.
The logic in getRootSuiteDirPath() method is not straight forward. Can we check
MAGENTO_BP . DIRECTORY_SEPARATOR . 'dev/tests/acceptance' and TEST_BP, If they are different, read both paths, otherwise, just read TEST_BP.
There was a problem hiding this comment.
changed logic as adobe, tested for all suite locations + unit tests and it works. Thanks
added additional path for standalone
|
Please fix static tests before merge |
fixed static checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added dev/tests/acceptance path of _suite to file to getFileCollection() if it's a valid path
Description
Fixed Issues (if relevant)
Contribution checklist