Skip to content

MQE-1957: Entity Deprecation Reference - Static Check #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 14, 2020
Merged

MQE-1957: Entity Deprecation Reference - Static Check #658

merged 7 commits into from
Apr 14, 2020

Conversation

jilu1
Copy link
Contributor

@jilu1 jilu1 commented Mar 26, 2020

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

coveralls commented Mar 26, 2020 •
edited
Loading

Coverage Status

Coverage increased (+1.1%) to 54.265% when pulling 101ead6 on MQE-1957 into 9799582 on MFTF3.0.0-RC2.

@jilu1 jilu1 changed the title Mqe 1957 MQE-1957: Entity Deprecation Reference - Static Check Mar 31, 2020
soumyau
soumyau suggested changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall 👍 some minor changes requested.

soumyau
soumyau suggested changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some additional comments. Needs unit tests fixed.

soumyau
soumyau approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@jilu1 jilu1 merged commit 155d846 into MFTF3.0.0-RC2 Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soumyau soumyau soumyau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jilu1 @coveralls @soumyau