Skip to content

magento/magento2-functional-testing-framework#61: Validate build:project was run before attempting to generate tests #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2018

Conversation

vasylmalanka
Copy link
Contributor

Description

Exception throwing has been added to test generation method in order to check if vendor/bin/robo build:project has been ran and .env configuration file has been filled in.

Fixed Issues (if relevant)

  1. Validate build:project was run before attempting to generate tests #61: Validate build:project was run before attempting to generate tests

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@vasylmalanka vasylmalanka requested a review from okolesnyk March 24, 2018 10:32
@coveralls
Copy link

coveralls commented Mar 24, 2018

Coverage Status

Coverage remained the same at 53.382% when pulling 9763062 on vasylmalanka:issue-61 into 08c089a on magento:CD-develop.

@okolesnyk okolesnyk merged commit 04fec9e into magento:CD-develop Mar 29, 2018
magento-devops-reposync-svc pushed a commit that referenced this pull request Jul 28, 2021
…2-functional-testing-framework-842

[Imported] 33295: Eliminate AspectMock from FileStorageTest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants