Skip to content

Removed invalid sample test name #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 24, 2020
Merged

Removed invalid sample test name #745

merged 4 commits into from
Jul 24, 2020

Conversation

Mohamed-Asar
Copy link
Contributor

Description

AdminLoginTest is not found in Magento 2.4, So I replaced with AdminLoginSuccessfulTest which is available in Magento 2.4

Affected Pages

https://devdocs.magento.com/mftf/docs/commands/mftf.html

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@magento-engcom-team magento-engcom-team added Partner: Ziffity partners-contribution Pull Request is created by Magento Partner labels Jun 24, 2020
@coveralls
Copy link

coveralls commented Jun 24, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 56.074% when pulling d400fca on Mohamed-Asar:remove-invalid-command into b8ae00d on magento:develop.

@soumyau soumyau requested a review from dobooth June 24, 2020 20:06
@soumyau
Copy link
Contributor

soumyau commented Jun 24, 2020

@Mohamed-Asar thank you for this pull request. Can you sign Adobe CLA.

@Mohamed-Asar
Copy link
Contributor Author

@soumyau Hi, I already signed Adobe CLA.

dobooth
dobooth previously approved these changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@dobooth dobooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we make additions to doc to the master branch, if this is for current code.

@dobooth dobooth added the DOC label Jul 24, 2020
@dobooth dobooth changed the base branch from develop to annual-docs July 24, 2020 14:01
@dobooth dobooth changed the base branch from annual-docs to develop July 24, 2020 14:01
@dobooth dobooth dismissed their stale review July 24, 2020 14:02

The base branch was changed.

@dobooth dobooth changed the base branch from develop to annual-docs July 24, 2020 14:02
@dobooth dobooth changed the base branch from annual-docs to develop July 24, 2020 14:02
tomreece
tomreece approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@tomreece tomreece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @dobooth also.

@tomreece tomreece merged commit d890e05 into magento:develop Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomreece tomreece tomreece approved these changes

@dobooth dobooth dobooth left review comments

Assignees
No one assigned
Labels
DOC Partner: Ziffity partners-contribution Pull Request is created by Magento Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Mohamed-Asar @coveralls @soumyau @tomreece @dobooth @magento-engcom-team @okolesnyk