33293: Eliminated AspectMock usage from PersistedObjectHandlerTest.php #853

anzin · 2021-07-15T08:27:14Z

Description

I've eliminated AspectMock usage from dev/tests/unit/Magento/FunctionalTestFramework/DataGenerator/Handlers/PersistedObjectHandlerTest.php

Fixed Issues (if relevant)

Fixes [MFTF] Replace AspectMock with PHPUnit for PersistedObjectHandlerTest magento2#33293:[MFTF] Replace AspectMock with PHPUnit for PersistedObjectHandlerTest

Contribution checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/verification tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)
Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

andrewbess

Hello @anzin
Thank you for your contributing.

jilu1 · 2021-07-21T00:45:27Z

@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework

magento-engcom-team · 2021-07-21T00:46:11Z

@jilu1 the pull request successfully imported.

jilu1 · 2021-07-21T16:58:52Z

src/Magento/FunctionalTestingFramework/DataGenerator/Persist/CurlHandler.php

+
+        return self::$INSTANCE;
+    }
+


@anzin CurlHandler is widely used in MFTF and called repeatedly in test runs. Changing it to singleton may not work. Let me know if you think otherwise.

Hello @jilu1, I added new changes by deleting singleton, please check if this solution is better.

Thank you.

jilu1 · 2021-07-22T15:49:52Z

Closed by accident. reopen it :)

bohdan-harniuk

Hello, @anzin!
Thank you, for your contribution! I like your implementation!

Hello, @jilu1!
This task was finished without creating new singletons, so it is not a blocker. You can proceed with the code review.

Thanks, Bohdan

jilu1 · 2021-07-23T13:56:50Z

@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework

magento-engcom-team · 2021-07-23T13:57:07Z

@jilu1, an error occurred during the Pull Request import.

jilu1 · 2021-07-23T14:46:54Z

@anzin Is this PR ready for review?

anzin · 2021-07-23T14:50:54Z

Hello, @jilu1 Yes, you can review this PR. @bohdan-harniuk has found one mistake and asked me to fix that. Now everything should be fine.

bohdan-harniuk

Hi, @jilu1!
You can review this PR.
Thanks, Bohdan

jilu1 · 2021-07-28T01:34:41Z

@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework

magento-engcom-team · 2021-07-28T01:35:08Z

@jilu1, an error occurred during the Pull Request import.

jilu1 · 2021-07-28T01:41:26Z

@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework

magento-engcom-team · 2021-07-28T01:42:11Z

@jilu1 the pull request successfully imported.

jilu1 · 2021-07-28T04:15:10Z

@anzin
Should you also update here
https://github.com/magento/magento2-functional-testing-framework/pull/853/files#diff-16310c27840f10b029f0073735a9e114d59562a084c5e38a109eacdbf3a05f5cR265?

Nice solution!

bohdan-harniuk · 2021-07-28T07:35:32Z

@anzin
Should you also update here
https://github.com/magento/magento2-functional-testing-framework/pull/853/files#diff-16310c27840f10b029f0073735a9e114d59562a084c5e38a109eacdbf3a05f5cR265?

Nice solution!

Hello, @jilu1!

Your link leads to the same PR and with outdated changes (I cannot see what you wanted to show).
Could you please check it and provide what do we need to change?

Thanks, Bohdan

jilu1 · 2021-07-28T13:43:41Z

@anzin
Should you also update here
https://github.com/magento/magento2-functional-testing-framework/pull/853/files#diff-16310c27840f10b029f0073735a9e114d59562a084c5e38a109eacdbf3a05f5cR265?
Nice solution!

Hello, @jilu1!

Your link leads to the same PR and with outdated changes (I cannot see what you wanted to show).
Could you please check it and provide what do we need to change?

Thanks, Bohdan

@bohdan-harniuk
I mean it looks like a missed update in line #264~#265 in PersistedObjectHandlerTest.php.

bohdan-harniuk · 2021-07-28T13:53:24Z

@anzin
Should you also update here
https://github.com/magento/magento2-functional-testing-framework/pull/853/files#diff-16310c27840f10b029f0073735a9e114d59562a084c5e38a109eacdbf3a05f5cR265?
Nice solution!

Hello, @jilu1!
Your link leads to the same PR and with outdated changes (I cannot see what you wanted to show).
Could you please check it and provide what do we need to change?
Thanks, Bohdan

@bohdan-harniuk
I mean it looks like a missed update in line #264~#265 in PersistedObjectHandlerTest.php.

Oh, I can see now!! Thank you, @jilu1! We will fix that!

bohdan-harniuk

Hello, @anzin!
Thank you for such a quick fix!

@jilu1, thank you for your help here with identifying missed parts of the update!
Now everything is fine, please, check it!

Thanks, Bohdan

33293: Eliminated AspectMock usage from PersistedObjectHandlerTest.php

d50f5b9

magento-engcom-team added Partner: Atwix partners-contribution Pull Request is created by Magento Partner labels Jul 15, 2021

33293: Fixed static-test

d46a66d

andrewbess approved these changes Jul 15, 2021

View reviewed changes

andrewbess previously approved these changes Jul 15, 2021

View reviewed changes

andrewbess requested a review from jilu1 July 15, 2021 09:59

jilu1 added accept in progress labels Jul 21, 2021

jilu1 removed the accept label Jul 21, 2021

jilu1 reviewed Jul 21, 2021

View reviewed changes

jilu1 added the needs update label Jul 21, 2021

andrewbess self-assigned this Jul 22, 2021

jilu1 closed this Jul 22, 2021

jilu1 reopened this Jul 22, 2021

anzin dismissed andrewbess’s stale review via 77e13bb July 22, 2021 20:29

anzin force-pushed the improvement/mftf-33293-eliminate-aspect-mock-from-persisted-object-handler-test branch from 77e13bb to 0c94ebb Compare July 22, 2021 20:33

33293: Removed Singleton and used Object Manager

45e2436

anzin force-pushed the improvement/mftf-33293-eliminate-aspect-mock-from-persisted-object-handler-test branch 2 times, most recently from eb6edc6 to 940373c Compare July 22, 2021 20:57

33293: Fixed static-test

842f9f5

anzin force-pushed the improvement/mftf-33293-eliminate-aspect-mock-from-persisted-object-handler-test branch from 940373c to 842f9f5 Compare July 22, 2021 21:01

bohdan-harniuk self-requested a review July 23, 2021 10:34

bohdan-harniuk previously approved these changes Jul 23, 2021

View reviewed changes

jilu1 removed the needs update label Jul 23, 2021

anzin dismissed bohdan-harniuk’s stale review via 04ea4ab July 23, 2021 14:44

bohdan-harniuk removed the in progress label Jul 23, 2021

bohdan-harniuk previously approved these changes Jul 23, 2021

View reviewed changes

bohdan-harniuk requested a review from jilu1 July 23, 2021 15:33

bohdan-harniuk mentioned this pull request Jul 26, 2021

Improvement/mftf 33583 eliminate aspect mock from mock module resolver builder #861

Merged

5 tasks

anzin mentioned this pull request Jul 26, 2021

33582: Eliminated AspectMock from MagentoTestCase.php #863

Merged

5 tasks

jilu1 added the in progress label Jul 26, 2021

bohdan-harniuk self-assigned this Jul 27, 2021

anzin mentioned this pull request Jul 27, 2021

Improvement/mftf 33584 eliminate aspect mock from object handler uti #865

Merged

5 tasks

jilu1 added needs update Award: advanced labels Jul 28, 2021

andrewbess previously approved these changes Jul 28, 2021

View reviewed changes

33293: Fixed code

63a1ed4

anzin dismissed stale reviews from andrewbess and bohdan-harniuk via 63a1ed4 July 28, 2021 14:03

bohdan-harniuk approved these changes Jul 28, 2021

View reviewed changes

jilu1 added accept and removed needs update labels Jul 28, 2021

magento-devops-reposync-svc merged commit c405497 into magento:develop Jul 28, 2021

magento-engcom-team removed the Award: advanced label Jul 28, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

33293: Eliminated AspectMock usage from PersistedObjectHandlerTest.php #853

33293: Eliminated AspectMock usage from PersistedObjectHandlerTest.php #853

anzin commented Jul 15, 2021 •

edited

Loading

andrewbess left a comment

jilu1 commented Jul 21, 2021

magento-engcom-team commented Jul 21, 2021

jilu1 Jul 21, 2021

anzin Jul 22, 2021

jilu1 commented Jul 22, 2021

bohdan-harniuk left a comment

jilu1 commented Jul 23, 2021

magento-engcom-team commented Jul 23, 2021

jilu1 commented Jul 23, 2021

anzin commented Jul 23, 2021 •

edited

Loading

bohdan-harniuk left a comment

jilu1 commented Jul 28, 2021

magento-engcom-team commented Jul 28, 2021

jilu1 commented Jul 28, 2021

magento-engcom-team commented Jul 28, 2021

jilu1 commented Jul 28, 2021

bohdan-harniuk commented Jul 28, 2021

jilu1 commented Jul 28, 2021

bohdan-harniuk commented Jul 28, 2021 •

edited

Loading

bohdan-harniuk left a comment

33293: Eliminated AspectMock usage from PersistedObjectHandlerTest.php #853

33293: Eliminated AspectMock usage from PersistedObjectHandlerTest.php #853

Conversation

anzin commented Jul 15, 2021 • edited Loading

Description

Fixed Issues (if relevant)

Contribution checklist

andrewbess left a comment

Choose a reason for hiding this comment

jilu1 commented Jul 21, 2021

magento-engcom-team commented Jul 21, 2021

jilu1 Jul 21, 2021

Choose a reason for hiding this comment

anzin Jul 22, 2021

Choose a reason for hiding this comment

jilu1 commented Jul 22, 2021

bohdan-harniuk left a comment

Choose a reason for hiding this comment

jilu1 commented Jul 23, 2021

magento-engcom-team commented Jul 23, 2021

jilu1 commented Jul 23, 2021

anzin commented Jul 23, 2021 • edited Loading

bohdan-harniuk left a comment

Choose a reason for hiding this comment

jilu1 commented Jul 28, 2021

magento-engcom-team commented Jul 28, 2021

jilu1 commented Jul 28, 2021

magento-engcom-team commented Jul 28, 2021

jilu1 commented Jul 28, 2021

bohdan-harniuk commented Jul 28, 2021

jilu1 commented Jul 28, 2021

bohdan-harniuk commented Jul 28, 2021 • edited Loading

bohdan-harniuk left a comment

Choose a reason for hiding this comment

anzin commented Jul 15, 2021 •

edited

Loading

anzin commented Jul 23, 2021 •

edited

Loading

bohdan-harniuk commented Jul 28, 2021 •

edited

Loading