-
Notifications
You must be signed in to change notification settings - Fork 132
Issue 33296: Eliminate AspectMock from OperationDataArrayResolverTest #855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, @karyna-tsymbal-atwix!
Thank you for your work here!
Hello, @jilu1!
This task was finished without creating new singletons, so it is not a blocker. You can proceed with the code review.
Thanks, Bohdan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @karyna-tsymbal-atwix
Thank you for your contribution.
It looks well for me.
@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework |
@jilu1 the pull request successfully imported. |
Description
Eliminated AspectMock usage from
dev/tests/unit/Magento/FunctionalTestFramework/DataGenerator/Persist/OperationDataArrayResolverTest.php
Fixed Issues (if relevant)
Contribution checklist