Skip to content

MQE-913: Nested Element Assertions Don’t Support Action Group Replacement #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 10, 2018
Merged

MQE-913: Nested Element Assertions Don’t Support Action Group Replacement #90

merged 5 commits into from
Apr 10, 2018

Conversation

KevinBKozan
Copy link
Contributor

Description

  • Fixed above bug. Attribute/argument resolution is now recursive.

Fixed Issues (if relevant)

  1. cannot use strings with comma sign in locatorFunction as it is wrapped with " which breaks Php #913: Nested Element Assertions Don’t Support Action Group Replacement

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@KevinBKozan
MQE-913: Nested Element Assertions Don’t Support Action Group Replace…
ac47332 
…ment

- actionGroupObj now recurses through the attributes, to be able to replace nested array attributes (asserts' expected/actual arrays)
@KevinBKozan
MQE-913: Nested Element Assertions Don’t Support Action Group Replace…
0b1a1bc 
…ment

- PHPCS fixes
@KevinBKozan
MQE-913: Nested Element Assertions Don’t Support Action Group Replace…
3847536 
…ment

- CR fix
@KevinBKozan
Merge branch 'develop' into MQE-913
3b5c8c2
@coveralls
Copy link

coveralls commented Apr 10, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 51.425% when pulling 9065b44 on MQE-913 into 4ece405 on develop.

@KevinBKozan KevinBKozan merged commit 274b2b0 into develop Apr 10, 2018
@KevinBKozan KevinBKozan deleted the MQE-913 branch April 10, 2018 19:25
magento-devops-reposync-svc pushed a commit that referenced this pull request Aug 3, 2021
@jilu1
Merge pull request #90 from magento-commerce/imported-magento-magento…
b2b628c 
…2-functional-testing-framework-844

[Imported] MFTF-33301: Eliminated AspectMock usage for TestObjectHandlerTest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KevinBKozan @coveralls