Skip to content

MQE-905: Persistent entity variable not interpolated with page urls with type "admin" #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 12, 2018
Merged

MQE-905: Persistent entity variable not interpolated with page urls with type "admin" #93

merged 5 commits into from
Apr 12, 2018

Conversation

KevinBKozan
Copy link
Contributor

@KevinBKozan KevinBKozan commented Apr 11, 2018 •
edited
Loading

Description

  • Fixed and refactored the wrapFunctionCall...() methods to iterate over args and format them as necessary before building the full function call.

Fixed Issues (if relevant)

  1. Fixed PHP 8.2 deprecation warnings: 'creation of dynamic property'. #905: Persistent entity variable not interpolated with page urls with type "admin"

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@KevinBKozan
MQE-905: Persistent entity variable not interpolated with page urls w…
6c77397 
…ith type "admin"

- resolveEnvReferences now alters the passed in set of $args, allowing further use of the new $args.
@KevinBKozan
Merge branch 'develop' into MQE-905
f0edcae
@KevinBKozan
MQE-905: Persistent entity variable not interpolated with page urls w…
2197615 
…ith type "admin"

- Refactored resolve* functions to consume and transform $args instead of the whole string.
@KevinBKozan
MQE-905: Persistent entity variable not interpolated with page urls w…
c623651 
…ith type "admin"

- CR Fixes
- verification fixes.
@KevinBKozan
Merge branch 'develop' into MQE-905
9967e23
@coveralls
Copy link

coveralls commented Apr 11, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 49.967% when pulling 9967e23 on MQE-905 into e2b88bf on develop.

@KevinBKozan KevinBKozan merged commit 5fe3796 into develop Apr 12, 2018
@KevinBKozan KevinBKozan deleted the MQE-905 branch April 12, 2018 13:19
magento-devops-reposync-svc pushed a commit that referenced this pull request Aug 5, 2021
@jilu1
Merge pull request #93 from magento-commerce/imported-magento-magento…
d0acaee 
…2-functional-testing-framework-855

[Imported] Issue 33296: Eliminate AspectMock from OperationDataArrayResolverTest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KevinBKozan @coveralls