Skip to content

Added module for support of Japanese characters in URLs. #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2019

Conversation

vkublytskyi
Copy link

By default, Magento allows only ASCII symbols in URL rewrites. This creates issues for Japanese merchants as Magento not able automatically generate URLs for products, categories, and CMS pages.

This module allows using national characters in URLs and adds transliterator that will try to transliterate Japanese text to roman. Transliterator may succeed only if Katakana or Hirgana is used in a text. For Kanji all URLs will contain Japanese text.

@orlangur
Copy link

@vkublytskyi shouldn't transliterators be more generic than just Japanese-specific?

@vkublytskyi
Copy link
Author

@orlangur it should. But to make it right for all available locales we need more deep research and more complex implementation. For example, if we will use Any-Latin ICU transliterator available with Intl PHP extension it may treat Japanese Kanji as Chinese symbols and lead to an incorrect result.

So, for now, in the scope of Magento Japanese Extensions, we made only changes required for the Japanese market and do not deliver anything to the core. You may also note several other modules such as CurrencyPrecision and ConfigurablePdfFont that may be fully moved to the core and modules such as JapanesePostalCode or JapaneseAddress that may be generalized to be useful in different regions. We are planning to stabilize code, verify solution and after that we will deliver improvements to the core. More information available in our Roadmap.

All modules from this repository will be available at Magento Composer Repository and marketplace with a possibility to install whole suite as well as each module individually.

@orlangur
Copy link

@vkublytskyi I'm not referring to concrete implementations, just it feels to me that extension point for transliterators should be placed somewhere in core. I remember such transliteration was already in place for Greek or Cyrillic alphabets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants