Skip to content

FIX #27117 Invalid functional Test names #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 18, 2020
Merged

FIX #27117 Invalid functional Test names #399

merged 3 commits into from
Mar 18, 2020

Conversation

lbajsarowicz
Copy link
Contributor

@lbajsarowicz lbajsarowicz commented Mar 1, 2020 •
edited
Loading

Description (*)

Fix the Test names, rename wrong files.
As a side effect, more tests can be run than previously.

Related Pull Requests

To be done later

Fixed Issues (if relevant)

  1. MFTF: Test names are not following Best Practices (Test suffix) magento2#27117

Manual testing scenarios (*)

N/A

Questions or comments

This change might cause hundreds of failures as previously ignored will be run now.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

This was referenced Mar 1, 2020
Merged
Merged
Closed
@lenaorobei
Copy link
Contributor

@lbajsarowicz could you please resolve conflicts here? Thanks.

@lbajsarowicz
Merge remote-tracking branch 'origin/develop' into refactor/test-names
16e2f00 
# Conflicts:
#	app/code/Magento/PageBuilder/Test/Mftf/Test/AdminCatalogCategoryPageBuilderTest.xml
#	app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockRenderLayoutContentTypesTest.xml
#	app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockRenderMediaContentTypesTest.xml
@lbajsarowicz
Copy link
Contributor Author

@lenaorobei Resolved conflicts. Actually, the "fixes" merged to the mainline should follow the standards (were not)

@magento-engcom-team magento-engcom-team merged commit 949b908 into magento:develop Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenaorobei lenaorobei lenaorobei approved these changes

Assignees
No one assigned
Labels
Partner: Mediotype partners-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lbajsarowicz @lenaorobei @magento-engcom-team