[Story] Developer can style content types output differently per viewport #621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replace ko-style binding for preview.html with pbStyles - override ko-style for master format rendering in iframe - convert styles block for saved content to inline styles for correct master format parsing - add csso library
|
@magento run all tests |
- remove logging
- remove logging
bluemwhitew
reviewed
Aug 27, 2020
app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/binding/style.ts
Outdated
Show resolved
Hide resolved
- Adding `removeAttribute()` Method
- Adding Converter to Remove `style` Attribute(s) from Page Builder
- Adding Integration Test(s)
- add stage to bindingContext - extend style binding - revert pbStyle to ko-style
|
@magento run Functional Tests EE |
- replace class with attribute - add minified library - fix style adding in preview style binding
|
@magento run Functional Tests EE |
- Refactoring Using DOMDocument - Adding `generateDataAttribute` Method - Adding `generateInternalStyles` Method - Modifying Ordering of Expected vs. Actual in PageBuilderStripStylesTest
- Code Review Feedback/Amends
- add id to body - make generated styles selectors more specific with body id
|
@magento run Functional Tests EE |
omiroshnichenko
changed the title
This was
linked to
issues
Sep 10, 2020
54 tasks
- Minor Refactoring
- Amending Integration Tests - Preparing to Utilise DOMDocument for Testing
…eBuilderCatalogProductAddAndEditRowColumnSlideTest test
…rt - Added new step
- fix BlockRenderSlideItemPosterAppearanceThroughBlockContentTypeTest
|
@magento run all tests |
- Extending MFTF Tests for CSS Specificity
- Correcting H2 Usage
- Extending MFTF Tests for CSS Responsive Styling - Removing Heading Type in CSS Specificity
Merged
4 tasks
- remove redundant layout - revert column-group styles back
m2-community-project
bot
added
Progress: ready for delivery
and removed
Progress: ready for delivery
labels
omiroshnichenko
changed the title
m2-community-project
bot
added
Progress: ready for delivery
and removed
Progress: ready for delivery
labels
…uilder into 558_extending-mftf-tests
- move, rename, change severity for tests
- fix generation
Extending MFTF Tests
|
@magento import pull request to magento-obsessive-owls/magento2-page-builder |
|
@omiroshnichenko the pull request successfully imported. |
m2-community-project
bot
added
Progress: done
and removed
Progress: ready for delivery
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n full-screen mode only
Description (*)
Added changes for overlay, when PageBuilder field is disabled.
Story
Related Pull Requests
magento/magento2#30565
https://github.com/magento/partners-magento2ee/pull/387
https://github.com/magento/magento2-page-builder-ee/pull/171
Checklist
Test Plan
TBD