27845 fix when qty or id not specified in grouped_options

Author: engcom-Charlie

app/code/Magento/GroupedProduct/Api/Data/GroupedOptionsInterface.php

@@ -17,16 +17,16 @@ interface GroupedOptionsInterface extends ExtensibleDataInterface
     /**
      * Get associated product id
      *
-     * @return int
+     * @return int|null
      */
-    public function getId(): int;
+    public function getId(): ?int;
 
     /**
      * Get associated product qty
      *
-     * @return int
+     * @return int|null
      */
-    public function getQty(): int;
+    public function getQty(): ?int;
 
     /**
      * Set extension attributes

app/code/Magento/GroupedProduct/Model/Quote/Item/CartItemProcessor.php

@@ -9,6 +9,8 @@
 
 use Magento\Framework\DataObject;
 use Magento\Framework\DataObject\Factory as ObjectFactory;
+use Magento\Framework\Exception\LocalizedException;
+use Magento\GroupedProduct\Api\Data\GroupedOptionsInterface;
 use Magento\GroupedProduct\Model\Product\Type\Grouped;
 use Magento\Quote\Api\Data as QuoteApi;
 use Magento\Quote\Api\Data\CartItemInterface;
@@ -71,17 +73,33 @@ public function convertToBuyRequest(CartItemInterface $cartItem): ?DataObject
             $groupedOptions = $cartItem->getProductOption()->getExtensionAttributes()->getGroupedOptions();
             $this->groupedOptions = $groupedOptions;
 
-            $requestData = [];
-            foreach ($groupedOptions as $item) {
-                $requestData[self::SUPER_GROUP_CODE][$item->getId()] = $item->getQty();
-            }
-
-            return $this->objectFactory->create($requestData);
+            return $this->objectFactory->create($this->getConvertedData($groupedOptions));
         }
 
         return null;
     }
 
+    /**
+     * Returns grouped_options converted to super_group data
+     *
+     * @param GroupedOptionsInterface[] $groupedOptions
+     * @return array
+     * @throws LocalizedException
+     */
+    private function getConvertedData(array $groupedOptions): array
+    {
+        $requestData = [];
+        foreach ($groupedOptions as $item) {
+            /** @var GroupedOptionsInterface $item */
+            if ($item->getQty() === null || $item->getId() === null) {
+                throw new LocalizedException(__('Please specify id and qty for grouped options.'));
+            }
+            $requestData[self::SUPER_GROUP_CODE][$item->getId()] = $item->getQty();
+        }
+
+        return $requestData;
+    }
+
     /**
      * Option processor
      *

app/code/Magento/GroupedProduct/Model/Quote/Item/GroupedOptions.php

@@ -16,12 +16,12 @@
 class GroupedOptions implements GroupedOptionsInterface
 {
     /**
-     * @var int
+     * @var int|null
      */
     private $qty;
 
     /**
-     * @var int
+     * @var int|null
      */
     private $id;
 
@@ -31,12 +31,15 @@ class GroupedOptions implements GroupedOptionsInterface
     private $extensionAttributes;
 
     /**
-     * @param int $id
-     * @param int $qty
+     * @param int|null $id
+     * @param int|null $qty
      * @param GroupedOptionsExtensionInterface|null $extensionAttributes
      */
-    public function __construct(int $id, int $qty, $extensionAttributes = null)
-    {
+    public function __construct(
+        ?int $id = null,
+        ?int $qty = null,
+        ?GroupedOptionsExtensionInterface $extensionAttributes = null
+    ) {
         $this->id = $id;
         $this->qty = $qty;
         $this->extensionAttributes = $extensionAttributes;
@@ -45,15 +48,15 @@ public function __construct(int $id, int $qty, $extensionAttributes = null)
     /**
      * @inheritDoc
      */
-    public function getId(): int
+    public function getId(): ?int
     {
         return $this->id;
     }
 
     /**
      * @inheritDoc
      */
-    public function getQty(): int
+    public function getQty(): ?int
     {
         return $this->qty;
     }