ENGCOM-8242: Cleaned up duplicate variable assignments in the same line #30120

 - Merge Pull Request #30120 from bgorski/magento2:duplicated-assignment-cleanup
 - Merged commits:
   1. baea0a2
   2. 4153286
   3. 7f2a29f
   4. 41b265e

Author: magento-engcom-team

app/code/Magento/CatalogSearch/Test/Unit/Model/Layer/Filter/CategoryTest.php

@@ -94,7 +94,7 @@ protected function setUp(): void
             ->setMethods(['getState', 'getProductCollection'])
             ->getMock();
 
-        $this->fulltextCollection = $this->fulltextCollection = $this->getMockBuilder(
+        $this->fulltextCollection = $this->getMockBuilder(
             Collection::class
         )
             ->disableOriginalConstructor()

app/code/Magento/CatalogSearch/Test/Unit/Model/Layer/Filter/DecimalTest.php

@@ -84,7 +84,7 @@ protected function setUp(): void
             ->method('create')
             ->willReturn($this->filterItem);
 
-        $this->fulltextCollection = $this->fulltextCollection = $this->getMockBuilder(
+        $this->fulltextCollection = $this->getMockBuilder(
             Collection::class
         )
             ->disableOriginalConstructor()

app/code/Magento/CatalogSearch/Test/Unit/Model/Layer/Filter/PriceTest.php

@@ -99,7 +99,7 @@ protected function setUp(): void
             ->method('getState')
             ->willReturn($this->state);
 
-        $this->fulltextCollection = $this->fulltextCollection = $this->getMockBuilder(
+        $this->fulltextCollection = $this->getMockBuilder(
             Collection::class
         )
             ->disableOriginalConstructor()

app/code/Magento/Reports/Block/Adminhtml/Grid.php

@@ -209,7 +209,7 @@ protected function _getAllowedStoreIds()
         } elseif ($this->getRequest()->getParam('website')) {
             $storeIds = $this->_storeManager->getWebsite($this->getRequest()->getParam('website'))->getStoreIds();
         } elseif ($this->getRequest()->getParam('group')) {
-            $storeIds = $storeIds = $this->_storeManager->getGroup(
+            $storeIds = $this->_storeManager->getGroup(
                 $this->getRequest()->getParam('group')
             )->getStoreIds();
         }

app/code/Magento/Sales/Model/Order/Payment.php

@@ -742,7 +742,7 @@ public function refund($creditmemo)
                 $this->formatPrice($baseAmountToRefund)
             );
         }
-        $message = $message = $this->prependMessage($message);
+        $message = $this->prependMessage($message);
         $message = $this->_appendTransactionToMessage($transaction, $message);
         $orderState = $this->getOrderStateResolver()->getStateForOrder($this->getOrder());
         $statuses = $this->getOrder()->getConfig()->getStateStatuses($orderState, false);

app/code/Magento/Tax/Model/Calculation/AbstractAggregateCalculator.php

@@ -21,7 +21,7 @@ protected function calculateWithTaxInPrice(QuoteDetailsItemInterface $item, $qua
             $this->taxClassManagement->getTaxClassId($item->getTaxClassKey())
         );
         $rate = $this->calculationTool->getRate($taxRateRequest);
-        $storeRate = $storeRate = $this->calculationTool->getStoreRate($taxRateRequest, $this->storeId);
+        $storeRate = $this->calculationTool->getStoreRate($taxRateRequest, $this->storeId);
 
         $discountTaxCompensationAmount = 0;
         $applyTaxAfterDiscount = $this->config->applyTaxAfterDiscount($this->storeId);

app/code/Magento/Tax/Model/Calculation/UnitBaseCalculator.php

@@ -10,7 +10,15 @@
 class UnitBaseCalculator extends AbstractCalculator
 {
     /**
-     * {@inheritdoc}
+     * Determines the rounding operation type and rounds the amount
+     *
+     * @param float $amount
+     * @param string $rate
+     * @param bool $direction
+     * @param string $type
+     * @param bool $round
+     * @param QuoteDetailsItemInterface $item
+     * @return float|string
      */
     protected function roundAmount(
         $amount,
@@ -31,15 +39,20 @@ protected function roundAmount(
     }
 
     /**
-     * {@inheritdoc}
+     * Calculate tax details for quote item with tax in price with given quantity
+     *
+     * @param QuoteDetailsItemInterface $item
+     * @param int $quantity
+     * @param bool $round
+     * @return \Magento\Tax\Api\Data\TaxDetailsItemInterface
      */
     protected function calculateWithTaxInPrice(QuoteDetailsItemInterface $item, $quantity, $round = true)
     {
         $taxRateRequest = $this->getAddressRateRequest()->setProductClassId(
             $this->taxClassManagement->getTaxClassId($item->getTaxClassKey())
         );
         $rate = $this->calculationTool->getRate($taxRateRequest);
-        $storeRate = $storeRate = $this->calculationTool->getStoreRate($taxRateRequest, $this->storeId);
+        $storeRate = $this->calculationTool->getStoreRate($taxRateRequest, $this->storeId);
 
         // Calculate $priceInclTax
         $applyTaxAfterDiscount = $this->config->applyTaxAfterDiscount($this->storeId);
@@ -104,7 +117,12 @@ protected function calculateWithTaxInPrice(QuoteDetailsItemInterface $item, $qua
     }
 
     /**
-     * {@inheritdoc}
+     * Calculate tax details for quote item with tax not in price with given quantity
+     *
+     * @param QuoteDetailsItemInterface $item
+     * @param int $quantity
+     * @param bool $round
+     * @return \Magento\Tax\Api\Data\TaxDetailsItemInterface
      */
     protected function calculateWithTaxNotInPrice(QuoteDetailsItemInterface $item, $quantity, $round = true)
     {