-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Cleaned up duplicate variable assignments in the same line #30120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaned up duplicate variable assignments in the same line #30120
Conversation
Hi @bgorski. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bgorski,
Could you fix the failing static tests for changed files?
Thank you!
@magento run Static Tests |
@magento run Static Tests |
@magento run Static Tests |
@magento run all tests |
@magento create issue |
Hi @ihor-sviziev, thank you for the review. |
Hi @bgorski, thank you for your contribution! |
Description (*)
Re-apply changes from #28085
This is a simple cleanup of two assignments to the same variable occurring in the same line.
Created by using the following regex:
($.*) = \1 = (with space before to exclude things like self::$loader = $loader = new \Composer\Autoload\ClassLoader(); and with space after to make sure it's an assignment and not anything else like ===)
And replacing with:
$1 = (also with space before and after to keep the formatting right)
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
none required
Contribution checklist (*)
Resolved issues: