🔃 [Magento Community Engineering] Community Contributions - 2.4-develop

Accepted Community Pull Requests:
 - #30402: #30388 : fix js error on edit review page (by @sunilit42)
 - #30502: add --no-tablespaces parameters to mysqldump (by @jonashrem)
 - #29911: Check if copy method is copy before sending comment email (by @JeroenVanLeusden)
 - #30493: Fixed placeholder translation in Magento UI grid search component (by @vveb-developer)
 - #30453: Fix missing escape less calc (by @mrtuvn)
 - #30079: [MFTF] add AdminOpenCustomersGridActionGroup (by @Usik2203)
 - #26967: Fix for queue numeric argument conversion (by @bartoszkubicki)
 - #28917: AppState emulateAreaCode was not respected by file collector (by @johan-lindahl)
 - #29196: Avoids endless loop of indexers being marked as invalid (by @hostep)


Fixed GitHub Issues:
 - #30388: Uncaught TypeError: Event.observe is not a function in admin review edit page (reported by @lng50k) has been fixed in #30402 by @sunilit42 in 2.4-develop branch
   Related commits:
     1. af2d29a
     2. e08499b
     3. a4be3e0
     4. a88f580
     5. 7ea4721

 - #30566: [Issue] add --no-tablespaces parameters to mysqldump (reported by @m2-assistant[bot]) has been fixed in #30502 by @jonashrem in 2.4-develop branch
   Related commits:
     1. 6f8021a
     2. 2bc78ad

 - #29915: [Issue] Check if copy method is copy before sending comment email (reported by @m2-assistant[bot]) has been fixed in #29911 by @JeroenVanLeusden in 2.4-develop branch
   Related commits:
     1. 78dd01a
     2. 35bbc82
     3. 902e1a2
     4. c7c4ad6

 - #30510: [Issue] Fixed placeholder translation in Magento UI grid search component (reported by @m2-assistant[bot]) has been fixed in #30493 by @vveb-developer in 2.4-develop branch
   Related commits:
     1. d10f1c8

 - #30542: [Issue] Fix missing escape less calc (reported by @m2-assistant[bot]) has been fixed in #30453 by @mrtuvn in 2.4-develop branch
   Related commits:
     1. 40134a6

 - #29615: [Issue] Fix for queue numeric argument conversion (reported by @m2-assistant[bot]) has been fixed in #26967 by @bartoszkubicki in 2.4-develop branch
   Related commits:
     1. d60cbb9
     2. 5e7d9f6
     3. 314ec92
     4. 69eca07
     5. 1fd7015
     6. 7e97fb4
     7. 8c8b9cf
     8. 0c6d204

 - #29656: [Issue] AppState emulateAreaCode was not respected by file collector (reported by @m2-assistant[bot]) has been fixed in #28917 by @johan-lindahl in 2.4-develop branch
   Related commits:
     1. 0ec2c91
     2. f35a8b6
     3. e724788
     4. 27767f1

 - #29297: Refactor Magento_Indexer module so that the "indexer_reindex_all_invalid" cronjob and "bin/magento indexer:reindex" command use the same code (reported by @hostep) has been fixed in #29196 by @hostep in 2.4-develop branch
   Related commits:
     1. f0c6453
     2. 07d4ac6
     3. e9359f1
     4. 6a58f7e
     5. bc2aab7
     6. f9f3725

 - #29478: [Issue] Avoids endless loop of indexers being marked as invalid (reported by @m2-assistant[bot]) has been fixed in #29196 by @hostep in 2.4-develop branch
   Related commits:
     1. f0c6453
     2. 07d4ac6
     3. e9359f1
     4. 6a58f7e
     5. bc2aab7
     6. f9f3725

Author: magento-engcom-team

app/code/Magento/Catalog/Test/Mftf/Test/CheckTierPricingOfProductsTest.xml

@@ -127,8 +127,7 @@
         <waitForPageLoad stepKey="waitForCustomersPage"/>
         <see userInput="You saved the customer." stepKey="CustomerIsSaved"/>
 
-        <amOnPage url="{{AdminCustomerPage.url}}" stepKey="navigateToCustomers"/>
-        <waitForPageLoad stepKey="waitForPageLoad1" />
+        <actionGroup ref="AdminOpenCustomersGridActionGroup" stepKey="navigateToCustomers"/>
         <click selector="{{AdminCustomerFiltersSection.clearAll}}" stepKey="ClearFilters"/>
         <waitForPageLoad stepKey="waitForFiltersClear"/>
 

app/code/Magento/Customer/Test/Mftf/ActionGroup/AdminOpenCustomersGridActionGroup.xml

@@ -0,0 +1,19 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ /**
+  * Copyright © Magento, Inc. All rights reserved.
+  * See COPYING.txt for license details.
+  */
+-->
+
+<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+              xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
+    <actionGroup name="AdminOpenCustomersGridActionGroup">
+        <annotations>
+            <description>Open the Admin Customers grid page.</description>
+        </annotations>
+
+        <amOnPage url="{{AdminCustomerPage.url}}" stepKey="openCustomersGridPage"/>
+        <waitForPageLoad stepKey="waitForPageLoad"/>
+    </actionGroup>
+</actionGroups>

app/code/Magento/Customer/Test/Mftf/ActionGroup/NavigateCustomerActionGroup.xml

@@ -8,7 +8,7 @@
 
 <actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
               xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
-    <actionGroup name="NavigateToAllCustomerPage">
+    <actionGroup name="NavigateToAllCustomerPage" deprecated="Use AdminOpenCustomersGridActionGroup instead.">
         <annotations>
             <description>Goes to the Admin Customers grid page.</description>
         </annotations>

app/code/Magento/Customer/Test/Mftf/Test/AdminAddNewDefaultBillingShippingCustomerAddressTest.xml

@@ -30,7 +30,7 @@
         Step2. On *Customers* page choose customer from preconditions and open it to edit
         Step3. Open *Addresses* tab on edit customer page and press *Add New Address* button
         <!- -->
-        <amOnPage url="{{AdminCustomerPage.url}}" stepKey="openCustomersGridPage"/>
+        <actionGroup ref="AdminOpenCustomersGridActionGroup" stepKey="openCustomersGridPage"/>
         <actionGroup ref="OpenEditCustomerFromAdminActionGroup" stepKey="openEditCustomerPage">
             <argument name="customer" value="Simple_US_Customer_Multiple_Addresses_No_Default_Address"/>
         </actionGroup>

app/code/Magento/Customer/Test/Mftf/Test/AdminChangeCustomerGenderInCustomersGridTest.xml

@@ -26,8 +26,7 @@
         <after>
             <deleteData createDataKey="createCustomer" stepKey="deleteCustomer"/>
             <!-- Reset customer grid filter -->
-            <amOnPage url="{{AdminCustomerPage.url}}" stepKey="goToCustomersGridPage"/>
-            <waitForPageLoad stepKey="waitForCustomersGrid"/>
+            <actionGroup ref="AdminOpenCustomersGridActionGroup" stepKey="goToCustomersGridPage"/>
             <actionGroup ref="AdminResetFilterInCustomerGrid" stepKey="resetFilter"/>
 
             <actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>

app/code/Magento/Customer/Test/Mftf/Test/AdminChangeSingleCustomerGroupViaGridTest.xml

@@ -29,12 +29,12 @@
             <!--Delete created data-->
             <deleteData createDataKey="createCustomer" stepKey="deleteCustomer"/>
             <deleteData createDataKey="createCustomerGroup" stepKey="deleteCustomerGroup"/>
-            <actionGroup ref="NavigateToAllCustomerPage" stepKey="navigateToCustomersPage"/>
+            <actionGroup ref="AdminOpenCustomersGridActionGroup" stepKey="navigateToCustomersPage"/>
             <actionGroup ref="ClearFiltersAdminDataGridActionGroup" stepKey="clearCustomersGridFilter"/>
             <actionGroup ref="AdminLogoutActionGroup" stepKey="logoutFromAdmin"/>
         </after>
 
-        <actionGroup ref="NavigateToAllCustomerPage" stepKey="navigateToCustomersPage"/>
+        <actionGroup ref="AdminOpenCustomersGridActionGroup" stepKey="navigateToCustomersPage"/>
         <actionGroup ref="AdminFilterCustomerGridByEmail" stepKey="filterCustomer">
             <argument name="email" value="$$createCustomer.email$$"/>
         </actionGroup>

app/code/Magento/Customer/Test/Mftf/Test/AdminCreateNewCustomerOnStorefrontSignupNewsletterTest.xml

@@ -35,8 +35,7 @@
         </actionGroup>
 
         <!--Assert verify created new customer in grid-->
-        <amOnPage url="{{AdminCustomerPage.url}}" stepKey="navigateToCustomers"/>
-        <waitForPageLoad stepKey="waitForNavigateToCustomersPageLoad"/>
+        <actionGroup ref="AdminOpenCustomersGridActionGroup" stepKey="navigateToCustomers"/>
         <click selector="{{AdminCustomerFiltersSection.filtersButton}}" stepKey="clickFilterButton"/>
         <fillField userInput="{{CustomerEntityOne.email}}" selector="{{AdminCustomerFiltersSection.emailInput}}" stepKey="filterEmail"/>
         <click selector="{{AdminCustomerFiltersSection.apply}}" stepKey="clickApplyFilter"/>

app/code/Magento/Customer/Test/Mftf/Test/AdminDeleteCustomerAddressesFromTheGridTest.xml

@@ -34,7 +34,7 @@
         Step2. On *Customers* page choose customer from preconditions and open it to edit
         Step3. On edit customer page open *Addresses* tab and find a grid with the additional addresses
         <!- -->
-        <amOnPage url="{{AdminCustomerPage.url}}" stepKey="openCustomersGridPage"/>
+        <actionGroup ref="AdminOpenCustomersGridActionGroup" stepKey="openCustomersGridPage"/>
         <actionGroup ref="OpenEditCustomerFromAdminActionGroup" stepKey="openEditCustomerPage">
             <argument name="customer" value="Simple_US_Customer_Multiple_Addresses"/>
         </actionGroup>

app/code/Magento/Customer/Test/Mftf/Test/AdminDeleteCustomerAddressesFromTheGridViaMassActionsTest.xml

@@ -34,7 +34,7 @@
         Step2. On *Customers* page choose customer from preconditions and open it to edit
         Step3. On edit customer page open *Addresses* tab and find a grid with the additional addresses
         <!- -->
-        <amOnPage url="{{AdminCustomerPage.url}}" stepKey="openCustomersGridPage"/>
+        <actionGroup ref="AdminOpenCustomersGridActionGroup" stepKey="openCustomersGridPage"/>
         <actionGroup ref="OpenEditCustomerFromAdminActionGroup" stepKey="openEditCustomerPage">
             <argument name="customer" value="Simple_US_Customer_Multiple_Addresses"/>
         </actionGroup>

app/code/Magento/Customer/Test/Mftf/Test/AdminDeleteDefaultBillingCustomerAddressTest.xml

@@ -33,7 +33,7 @@
         Step1. Login to admin and go to Customers > All Customers.
         Step2. On *Customers* page choose customer from preconditions and open it to edit
         <!- -->
-        <amOnPage url="{{AdminCustomerPage.url}}" stepKey="openCustomersGridPage"/>
+        <actionGroup ref="AdminOpenCustomersGridActionGroup" stepKey="openCustomersGridPage"/>
         <actionGroup ref="OpenEditCustomerFromAdminActionGroup" stepKey="openEditCustomerPage">
             <argument name="customer" value="Simple_US_Customer_Multiple_Addresses"/>
         </actionGroup>

app/code/Magento/Customer/Test/Mftf/Test/AdminEditDefaultBillingShippingCustomerAddressTest.xml

@@ -30,7 +30,7 @@
         Step2. On *Customers* page choose customer from preconditions and open it to edit
         Step3. Open *Addresses* tab on edit customer page and press *Add New Address* button
         <!- -->
-        <amOnPage url="{{AdminCustomerPage.url}}" stepKey="openCustomersGridPage"/>
+        <actionGroup ref="AdminOpenCustomersGridActionGroup" stepKey="openCustomersGridPage"/>
         <actionGroup ref="OpenEditCustomerFromAdminActionGroup" stepKey="openEditCustomerPage">
             <argument name="customer" value="Simple_US_Customer_Multiple_Addresses"/>
         </actionGroup>

app/code/Magento/Customer/Test/Mftf/Test/AdminExactMatchSearchInCustomerGridTest.xml

@@ -28,12 +28,12 @@
         <after>
             <deleteData createDataKey="createFirstCustomer" stepKey="deleteFirstCustomer"/>
             <deleteData createDataKey="createSecondCustomer" stepKey="deleteSecondCustomer"/>
-            <amOnPage url="{{AdminCustomerPage.url}}" stepKey="openCustomersGridPage"/>
+            <actionGroup ref="AdminOpenCustomersGridActionGroup" stepKey="openCustomersGridPage"/>
             <actionGroup ref="AdminResetFilterInCustomerAddressGrid" stepKey="clearCustomerGridFilter"/>
             <actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
         </after>
         <!--Step 1: Go to Customers > All Customers-->
-        <amOnPage url="{{AdminCustomerPage.url}}" stepKey="openCustomersGridPage"/>
+        <actionGroup ref="AdminOpenCustomersGridActionGroup" stepKey="openCustomersGridPage"/>
         <!--Step 2: On Customers grid page search customer by keyword with quotes-->
         <actionGroup ref="SearchAdminDataGridByKeywordActionGroup" stepKey="searchCustomer">
             <argument name="keyword" value="$$createSecondCustomer.firstname$$"/>

app/code/Magento/Customer/Test/Mftf/Test/AdminGridSearchSelectAllTest.xml

@@ -29,7 +29,7 @@
             <deleteData createDataKey="secondCustomer" stepKey="deleteSecondCustomer"/>
             <actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
         </after>
-        <amOnPage url="{{AdminCustomerPage.url}}" stepKey="openCustomerPage"/>
+        <actionGroup ref="AdminOpenCustomersGridActionGroup" stepKey="openCustomerPage"/>
         <!-- search Admin Data Grid By Keyword -->
         <conditionalClick selector="{{AdminDataGridHeaderSection.clearFilters}}" dependentSelector="{{AdminDataGridHeaderSection.clearFilters}}" visible="true" stepKey="clickClearFilters"/>
         <fillField selector="{{AdminDataGridHeaderSection.search}}" userInput="$$secondCustomer.email$$" stepKey="fillKeywordSearchFieldWithSecondCustomerEmail"/>

app/code/Magento/Customer/Test/Mftf/Test/AdminGridSelectAllOnPageTest.xml

@@ -30,7 +30,7 @@
             <deleteData createDataKey="thirdCustomer" stepKey="deleteThirdCustomer"/>
             <actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
         </after>
-        <amOnPage url="{{AdminCustomerPage.url}}" stepKey="openCustomerPage"/>
+        <actionGroup ref="AdminOpenCustomersGridActionGroup" stepKey="openCustomerPage"/>
         <!-- Select all from dropdown -->
         <actionGroup ref="ClearFiltersAdminDataGridActionGroup" stepKey="clearFilters" />
         <actionGroup ref="AdminGridSelectAllActionGroup" stepKey="selectAllCustomers"/>

app/code/Magento/Customer/Test/Mftf/Test/AdminSearchCustomerAddressByKeywordTest.xml

@@ -34,7 +34,7 @@
         Step2. On *Customers* page choose customer from preconditions and open it to edit
         Step3. On edit customer page open *Addresses* tab and find a grid with the additional addresses
         <!- -->
-        <amOnPage url="{{AdminCustomerPage.url}}" stepKey="openCustomersGridPage"/>
+        <actionGroup ref="AdminOpenCustomersGridActionGroup" stepKey="openCustomersGridPage"/>
         <actionGroup ref="OpenEditCustomerFromAdminActionGroup" stepKey="openEditCustomerPage">
             <argument name="customer" value="Simple_US_Customer_Multiple_Addresses"/>
         </actionGroup>

app/code/Magento/Customer/Test/Mftf/Test/AdminSetCustomerDefaultBillingAddressTest.xml

@@ -30,7 +30,7 @@
         Step2. On *Customers* page choose customer from preconditions and open it to edit
         Step3. On edit customer page open *Addresses* tab and find a grid with the additional addresses
         <!- -->
-        <amOnPage url="{{AdminCustomerPage.url}}" stepKey="openCustomersGridPage"/>
+        <actionGroup ref="AdminOpenCustomersGridActionGroup" stepKey="openCustomersGridPage"/>
         <actionGroup ref="OpenEditCustomerFromAdminActionGroup" stepKey="openEditCustomerPage">
             <argument name="customer" value="Simple_US_Customer_Multiple_Addresses_No_Default_Address"/>
         </actionGroup>

app/code/Magento/Customer/Test/Mftf/Test/AdminSetCustomerDefaultShippingAddressTest.xml

@@ -30,7 +30,7 @@
         Step2. On *Customers* page choose customer from preconditions and open it to edit
         Step3. On edit customer page open *Addresses* tab and find a grid with the additional addresses
         <!- -->
-        <amOnPage url="{{AdminCustomerPage.url}}" stepKey="openCustomersGridPage"/>
+        <actionGroup ref="AdminOpenCustomersGridActionGroup" stepKey="openCustomersGridPage"/>
         <actionGroup ref="OpenEditCustomerFromAdminActionGroup" stepKey="openEditCustomerPage">
             <argument name="customer" value="Simple_US_Customer_Multiple_Addresses_No_Default_Address"/>
         </actionGroup>

app/code/Magento/Customer/Test/Mftf/Test/AdminUpdateCustomerTest/AdminUpdateCustomerInfoFromDefaultToNonDefaultTest.xml

@@ -27,9 +27,7 @@
         </before>
         <after>
             <deleteData stepKey="deleteCustomer" createDataKey="customer"/>
-            <!-- Reset customer grid filter -->
-            <amOnPage stepKey="goToCustomersGridPage" url="{{AdminCustomerPage.url}}"/>
-            <waitForPageLoad stepKey="waitForCustomersGrid"/>
+            <actionGroup ref="AdminOpenCustomersGridActionGroup" stepKey="goToCustomersGridPage"/>
             <actionGroup stepKey="resetFilter" ref="AdminResetFilterInCustomerGrid"/>
             <actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
         </after>
@@ -47,9 +45,7 @@
             <argument name="customerAddress" value="CustomerAddressSimple"/>
         </actionGroup>
         <actionGroup stepKey="saveAndCheckSuccessMessage" ref="AdminSaveCustomerAndAssertSuccessMessage"/>
-        <!-- Assert Customer in Customer grid -->
-        <amOnPage stepKey="goToCustomersGridPage" url="{{AdminCustomerPage.url}}"/>
-        <waitForPageLoad stepKey="waitForCustomersGrid"/>
+        <actionGroup ref="AdminOpenCustomersGridActionGroup" stepKey="goToCustomersGridPage"/>
         <actionGroup stepKey="resetFilter" ref="AdminResetFilterInCustomerGrid"/>
         <actionGroup stepKey="filterByEamil" ref="AdminFilterCustomerGridByEmail">
             <argument name="email" value="updated$$customer.email$$"/>

app/code/Magento/Customer/Test/Mftf/Test/AdminVerifyCustomerAddressStateContainValuesOnceTest.xml

@@ -31,9 +31,7 @@
             <actionGroup ref="AdminClearCustomersFiltersActionGroup" stepKey="clearFilters"/>
             <actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
         </after>
-
-        <!-- Go to Customers > All Customers.-->
-        <amOnPage url="{{AdminCustomerPage.url}}" stepKey="openCustomersGridPage"/>
+        <actionGroup ref="AdminOpenCustomersGridActionGroup" stepKey="openCustomersGridPage"/>
 
         <!--Select created customer, Click Edit mode-->
         <actionGroup ref="OpenEditCustomerFromAdminActionGroup" stepKey="openEditCustomerPageWithAddresses">

app/code/Magento/Customer/Test/Mftf/Test/AllowedCountriesRestrictionApplyOnBackendTest.xml

@@ -116,8 +116,7 @@
         <waitForPageLoad stepKey="waitForCustomersPage"/>
         <!--Go to Customers grid and check that filter countries amount is the same as initial allowed countries amount-->
         <comment userInput="Go to Customers grid and check that filter countries amount is the same as initial allowed countries amount" stepKey="compareCountriesAmount"/>
-        <amOnPage url="{{AdminCustomerPage.url}}" stepKey="goToCustomersGrid"/>
-        <waitForPageLoad stepKey="waitForCustomersGrid"/>
+        <actionGroup ref="AdminOpenCustomersGridActionGroup" stepKey="goToCustomersGrid"/>
         <click selector="{{AdminDataGridHeaderSection.filters}}" stepKey="openFiltersSectionOnCustomersGrid"/>
         <executeJS function="var len = document.querySelectorAll('{{AdminCustomerFiltersSection.countryOptions}}').length; return len-1;" stepKey="countriesAmount2"/>
         <assertEquals stepKey="assertCountryAmounts">

app/code/Magento/Customer/Test/Mftf/Test/SearchByEmailInCustomerGridTest.xml

@@ -26,12 +26,12 @@
         <after>
             <deleteData createDataKey="createFirstCustomer" stepKey="deleteFirstCustomer"/>
             <deleteData createDataKey="createSecondCustomer" stepKey="deleteSecondCustomer"/>
-            <amOnPage url="{{AdminCustomerPage.url}}" stepKey="openCustomersGridPage"/>
+            <actionGroup ref="AdminOpenCustomersGridActionGroup" stepKey="openCustomersGridPage"/>
             <actionGroup ref="AdminResetFilterInCustomerAddressGrid" stepKey="clearCustomerGridFilter"/>
             <actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
         </after>
         <!--Step 1: Go to Customers > All Customers-->
-        <amOnPage url="{{AdminCustomerPage.url}}" stepKey="openCustomersGridPage"/>
+        <actionGroup ref="AdminOpenCustomersGridActionGroup" stepKey="openCustomersGridPage"/>
         <!--Step 2: On Customers grid page search customer by keyword-->
         <actionGroup ref="SearchAdminDataGridByKeywordActionGroup" stepKey="searchCustomer">
             <argument name="keyword" value="$$createSecondCustomer.email$$"/>