Skip to content

[Issue] Check if copy method is copy before sending comment email #29915

Closed
@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #29911: Check if copy method is copy before sending comment email


Preconditions (*)

Magento 2.4-develop

As seen in the comments email copies should only be sent as separated emails if their copy method is copy.

Screenshot from 2020-10-19 10-28-34

Steps to reproduce: (*)

  1. Go to Admin -> Stores -> Configuration -> Sales -> Sales Email -> Order Comments and set Enabled to Yes
  2. Add email address to Send Order Comment Email Copy To
  3. Set Send Order Comments Email Copy Method to Bcc
  4. Place order.
  5. Add order comment in order overview (adminhtml area) and uncheck notify customer.

Actual Result: ✖️ a copy of the email was sent

Screenshot from 2020-10-16 15-07-38

Expected Result: ✔️ Email copy should not be send because notify customer is disabled and copy set to bcc.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Metadata

Metadata

Labels

Component: SalesEvent: MageCONF CD 2020Fixed in 2.4.xThe issue has been fixed in 2.4-develop branchIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentPriority: P2A defect with this priority could have functionality issues which are not to expectations.Progress: doneReported on 2.4.0Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchSeverity: S3Affects non-critical data or functionality and does not force users to employ a workaround.

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions