Skip to content

Concurrent (quick reload) requests on checkout cause cart to empty - related to session_regenerate_id #12362

Closed
@minlare

Description

@minlare

Preconditions

  1. Magento 2.2.0
  2. PHP7

Steps to reproduce

  1. Add product to cart
  2. Navigate to checkout
  3. Reload the page as quick as possible (F5 multiple times)

Expected result

  1. Reload the checkout as usual
  2. Cart contains session items

Actual result

  1. Redirects to empty cart
  2. session_id() is old session id (previous request regenerated a new session_id, but this request has old session_id)

http://php.net/manual/en/function.session-regenerate-id.php

In https://github.com/magento/magento2/blob/2.2-develop/lib/internal/Magento/Framework/Session/SessionManager.php#L507 you reference http://php.net/manual/en/function.session-regenerate-id.php#53480 however I believe on concurrent requests this does not work correctly...

Metadata

Metadata

Assignees

No one assigned

    Labels

    Fixed in 2.2.xThe issue has been fixed in 2.2 release lineFixed in 2.3.xThe issue has been fixed in 2.3 release lineIssue: Clear DescriptionGate 2 Passed. Manual verification of the issue description passedIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentReproduced on 2.1.xThe issue has been reproduced on latest 2.1 releaseReproduced on 2.2.xThe issue has been reproduced on latest 2.2 releaseReproduced on 2.3.xThe issue has been reproduced on latest 2.3 release

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions