Translation in html files using $t() broken?

[amenk]

I use beta4 and switched the store language to de_DE. While many strings are just not yet translated to DE, there is a translation in app/code/Magento/Checkout/i18n/de_DE.csv for example for

"Shipping Address",Lieferungsadresse

If I am getting it correctly, this is referenced in app/code/Magento/Checkout/view/frontend/web/template/shipping.html:8

<div class="step-title" data-bind="text: $t('Shipping Address')" data-role="title"></div>

But still the English text is shown.

Is the Javascript translation currently broken?

[chicgeek]

Just want to add another example where I've experienced the same issue, though the string is not in a template file. In my case trying to translate a string in a core JS file (no override):

 app/code/Magento/Catalog/view/frontend/web/js/catalog-add-to-cart.js

String example:

$t('Adding...')

Translation in app/design/frontend/Project/default/i18n/en_GB.csv as:

"Adding...","foo…"

Other translations in this theme locale file work fine for in-template translations.

[amenk]

Translation seems to run via static/frontend/Vendor/theme/de_DE/js-translation.json - some strings are just not there. Have to find out, how this is generated.

[amenk]

Translation is fetched in \Magento\Translation\Model\Js\DataProvider::getData and \Magento\Translation\Model\Js\DataProvider::getPhrases. Magento fetches a list of all JS files and then does a preg_match for currently only the pattern ~\$\.mage\.__\([\'|\"](.+?)[\'|\"]\)~.
What has to be fixed:

• include .html templates to the list of files
• match also for $t('...')

[amenk]

I will try to make a PR...

[amenk]

It is already fixed in the develop branch by a commit from July https://github.com/magento/magento2/blob/develop/app/code/Magento/Translation/Model/Js/DataProvider.php#L96 - I am wondering why this is not yet in master.

[gordonknoppe]

Internal issue MAGETWO-43935

[Zatara7]

Is this the part that wasn't being translated? @amenk If so, then it still hasn't been fixed because this is the latest develop and we still need to fix it. If it isn't the part you're talking about then could you please point out how to get there?
Also, if it's been fixed in develop then please use develop for now until the next release when we merge everything to master.

[amenk]

I did not followup this. But I checked the js-translate.json and it looked good. I can currently use develop, because I use composer and do not want to mess with that process at the moment. I hope there will soon be another composer release?

[Zatara7]

@amenk Yes there is going to be a release soon. But could you please confirm if my screenshot is looking at the correct place in the frontend where you were having this issue?

[amenk]

Should roughly be the correct place. But I am using the blank theme and I think there is no such popup.

[Zatara7]

Okay let me switch themes and try again

[Zatara7]

Popup still there with the new theme. We'll get the translation fixed for the popup. Thanks

[arkadiych]

@chicgeek, thank you for reporting of the translation issue.
The issue, that you've mentioned in
app/code/Magento/Catalog/view/frontend/web/js/catalog-add-to-cart.js
relates to different from $t() problem.
Internal issue MAGETWO-44263 has been created.

[chicgeek]

@arkadiych Okay, is there an internal ticket / further discussion for my issue with $t()? I should note also that this is not isolated to catalog-add-to-cart.js: it affects all JS files and KO templates.

[arkadiych]

@chicgeek, MAGETWO-44263 should cover all entries of such type of untranslatable phrases.