Cms block cache key does not contain the store id

[tzyganu]

Preconditions (*)

1. Magento version 2.2.6
2. create one block that contains a {{trans}} directive. Or 2 blocks with the same identifier but each one available on a different store view
3. Block cache must be enabled.

Steps to reproduce (*)

1. Add the block in the layout and specify a cache lifetime

            <block class="Magento\Cms\Block\Block" name="some-name-here">
                <arguments>
                    <argument name="block_id" xsi:type="string">block-identifier-here</argument>
                    <argument name="cache_lifetime" xsi:type="number">84600</argument>
                </arguments>
            </block>

Expected result (*)

1. Loading the pages that contain this block on 2 different store views will show the proper content of the block for each website

Actual result (*)

1. Opening the page that contains the block on the second store view shows the cached version of the block from the first store view.

Additional info:

This happens because the cache key of the cms block is determined by Magento\Framework\View\Element\AbstractBlock::getCacheKey which calls getCacheKeyInfo from the same class which returns an array with the name of the block in the layout.

Possible solution:

Adding the store id to the cache key or to the array returned by getCacheKeyInfo.

[m2-assistant]

Hi @tzyganu. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@tzyganu do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[m2-assistant]

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

HI @tzyganu thank you for you report, Would you like to create Pull Request with this ?

[tzyganu]

@engcom-backlog-nazar If you really want me to do it, sure. Unless you want to take over. if you do, I won't oppose.

[magento-engcom-team]

✅ Confirmed by @engcom-backlog-nazar
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-99156, MAGETWO-99157 were created

Issue Available: @engcom-backlog-nazar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.