Use of undefined constant GLOB_BRACE in dependency "allure-framework/allure-phpunit"

[Flyingmana]

Preconditions (*)

Magento Version: 2.3.2

Steps to reproduce (*)

./bin/magento dev:test:run unit

Expected result (*)

No PHP Warnings

Actual result (*)

several:

Warning: Use of undefined constant GLOB_BRACE - assumed 'GLOB_BRACE' (this will throw an Error in a future version of PHP) in /var/www/html/src/vendor/allure-framework/allure-phpunit/src/Yandex/Allure/Adapter/AllureAdapter.php:74.

Related Informations

Problem is, GLOB_BRACE is not available in alle Unix Systems.
For example the often in Docker context used "Alpine"
docker-library/php#719

There is an (not merged) upstream PullRequest available in allure-framework/allure-phpunit#44
But I did not check yet, if this is the proper solution.

[m2-assistant]

Hi @Flyingmana. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@Flyingmana do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[m2-assistant]

Hi @engcom-Charlie. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Charlie]

Hello @Flyingmana !
Could you show me where(
outside the vendor) Magento uses GLOB_BRACE constant?

[engcom-Charlie]

I am closing this issue now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

[ksaho2]

For future reference here is a solution:
vendor/allure-framework/allure-phpunit/src/Yandex/Allure/Adapter/AllureAdapter.php@74

//            $files = glob($outputDirectory . DIRECTORY_SEPARATOR . '{,.}*', GLOB_BRACE);
//            foreach ($files as $file) {
//                if (is_file($file)) {
//                    unlink($file);
//                }
//            }

Comment out this code, or replace it with:

$directoryPath = $outputDirectory . DIRECTORY_SEPARATOR;
$dir = scandir($directoryPath);
$rel = ['.', '..'];
$files = array_diff($dir, $rel);

foreach ($files as $file) {
    $path = $directoryPath . $file;
    if (is_file($path)) {
        unlink($path);
    }
}

[duhon]

The solution to the problem is the pull request allure-framework/allure-phpunit#44 which the author may accept

[Flyingmana]

@engcom-Charlie its indirectly used by for example in

magento2/dev/tests/static/phpunit-all.xml.dist

Line 27 in c4fb1ee

<listener class="Yandex\Allure\Adapter\AllureAdapter">

[engcom-Charlie]

@Flyingmana since this problem is related to Allure, we can just wait when PR allure-framework/allure-phpunit#44 (comment) will be confirmed.
We hope the fix will be merged in the next Magento release(2.3.4).

[Flyingmana]

@engcom-Charlie thats not completely right.
As a good OpenSource User, you can also test the solution, communicate them that it works, and encourage them to merge it, because it is a part, which affects your own Users.

Usually its a good and helpfull thing for maintainers, to hear this also from the bigger users of an open source library/tool.

[fredden]

Upstream have released version 1.3.1, which includes this fix: allure-framework/allure-phpunit#44 (comment)
It looks like there's a dependency chain preventing this upgrade however:

• allure-framework/allure-phpunit 1.3.1 requires phpunit/phpunit >=7.0.0
• codeception/phpunit-wrapper 6.7.0 requires phpunit/phpunit >=6.5.13 <7.0
• codeception/codeception 2.4.5 requires codeception/phpunit-wrapper ^6.0.9|^7.0.6
• allure-framework/allure-codeception 1.3.0 requires codeception/codeception ~2.1
• magento/magento2-functional-testing-framework 2.5.4 requires allure-framework/allure-codeception ~1.3.0
• No suitable versions of magento/magento2-functional-testing-framework currently available.

(Reopening as this clearly isn't solved yet.)