Skip to content

[Issue] 'Ship Here' in CamelCase as that's how it is written elsewhere #28685

Closed
@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #28547: 'Ship Here' in CamelCase as that's how it is written elsewhere


Preconditions (*)

In the checkout shipping address modal the text in the primary button was written with a lowercase 'h'. On all other places, and in the translation files, it is written with a capital: 'Ship Here'. As a result, the button with the lowercase version 'Ship here' isn't translated.

  1. Has a simple product;
  2. Logged as Customer to Storefront with at least 1 saved address;

Steps to reproduce:

  1. Add translation for "Ship Here" in translation file; ("Ship Here","Ship Here (translated)" for ex.);
  2. Add product to Cart;
  3. Click on "Proceed to Checkout" button;
  4. Click on "+ New Address" button;

Actual Result: ✖️ The phrase was not translated

screenshot_47

Expected Result: ✔️ The phrase was successfully translated

screenshot_48

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Component: CheckoutComponent: TranslationIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentPriority: P3May be fixed according to the position in the backlog.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchSeverity: S3Affects non-critical data or functionality and does not force users to employ a workaround.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions