Closed
Description
This issue is automatically created based on existing pull request: #27616: Load appropriate slider widget on demand to improve performance
Description (*)
This PR is a part of my effort to improve Magento 2 frontend performance.
Because of the fact that all Knockout bindings are registered on every load, there are many dependencies requested no matter if such binding is even used on the page. Changes in this PR include:
- Touch slider widget customization is moved to a separate file so it can be loaded only on compatible devices.
- Appropriate slider widget type is loaded on-demand, only when range binding is actually used on the page.
Preconditions (*)
1.Magento 2.4-develop
Steps to reproduce (*)
- Add the range slider widget to the page, e.g. by adding the following HTML to the CMS block:
<div class="timeline-scale"></div>
<div class="data-slider" data-bind="{"range":{
"value": ko.observable(50),
"min": 1,
"max": 100,
"step": 5
}}"> </div>
</div>
- Validate that it works for both mouse and touch.
Expected result (*)
Actual result (*)
- [Screenshots, logs or description]
Contribution checklist (*)
- Pull request has a meaningful description of its purpose
- All commits are accompanied by meaningful commit messages
- All new or changed code is covered with unit/integration tests (if applicable)
- All automated tests passed successfully (all builds are green)
Metadata
Metadata
Assignees
Labels
The issue has been fixed in 2.4-develop branchGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 1 Passed. Automatic verification of issue format passedGate 4. Acknowledged. Issue is added to backlog and ready for developmentMay be fixed according to the position in the backlog.Indicates original Magento version for the Issue report.The issue has been reproduced on latest 2.4-develop branchMajor restrictions or short-term circumventions are required until a fix is available.Has been reviewed and prioritized during Triage with Product Managers
Type
Projects
Status
Done