Product Attribute Repository do not respect attribute_code max length

[drc0]

Preconditions (*)

on magento 2.4 a product attribute code with attribute_code of value A_12345678_9123_4567_890a_BCDEF123456 is saved through the admin ui but not from the repository. Here Magento\Eav\Model\Entity\Attribute::ATTRIBUTE_CODE_MAX_LENGTH should be respected.

Steps to reproduce (*)

Here is a code example:

$objectManager = \Magento\Framework\App\ObjectManager::getInstance();
$ar = $objectManager->create('Magento\Catalog\Api\ProductAttributeRepositoryInterface');
$attf = $objectManager->create('\Magento\Catalog\Api\Data\ProductAttributeInterfaceFactory');
$a = $attf->create();
$a->setData(['attribute_code' => 'A_12345678_9123_4567_890a_BCDEF123456','frontend_label' => 'a test', 'frontend_input' => 'text']);
$ar->save($a);
    Magento/Framework/Exception/InputException with message 'Invalid value of "A_12345678_9123_4567_890a_BCDEF123456" provided for the attribute_code field.'

Expected result (*)

1. attribute is saved

Actual result (*)

1. validator exception

Addiotional information

Issue is reproducible via WebApi

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @drc0. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[engcom-Charlie]

Hi, @drc0 I think that issue is in absent attribute code validation via admin.
What do you think?

[drc0]

I think that issue is in absent attribute code validation via admin.

with magento 2.4.0 I'm not able to reproduce the admin issue anymore (the string is 61 characters ), do you?

here I see the add field for the attribute_code field that respects that maximum length constant

magento2/app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Edit/Tab/Advanced.php

Lines 95 to 112 in b87f1df

	$validateClass = sprintf(
	'validate-code validate-length maximum-length-%d',
	\Magento\Eav\Model\Entity\Attribute::ATTRIBUTE_CODE_MAX_LENGTH
	);
	$fieldset->addField(
	'attribute_code',
	'text',
	[
	'name' => 'attribute_code',
	'label' => __('Attribute Code'),
	'title' => __('Attribute Code'),
	'note' => __(
	'This is used internally. Make sure you don\'t use spaces or more than %1 symbols.',
	\Magento\Eav\Model\Entity\Attribute::ATTRIBUTE_CODE_MAX_LENGTH
	),
	'class' => $validateClass
	]
	);

[engcom-Charlie]

@drc0 so can I close the issue?

[drc0]

Sure. Thanks. Il 3 settembre 2020 08:55:50 CEST, Vadim Malesh <notifications@github.com> ha scritto:

…

@drc0 so can I close the issue? -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #29017 (comment)

-- Inviato dal mio dispositivo Android con K-9 Mail. Perdonate la brevità.