Skip to content

[Issue] improve and make more strict autoload.php #29527

Closed
@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #28923: improve and make more strict autoload.php


Preconditions (*)

two improvements:

  1. use is_readable instead of file_exists. if we use require or include on a existing file that is not readable php generate errors. So we need to chech if file_exists and is_readable (is_readable do both things)
  2. provide an anonymous function to determinate $vendorAutoload, it's allow us to have a more readable code with early return.

Related Pull Requests

none

Fixed Issues (if relevant)

none

Steps to reproduce(*)

not necessary, if CI passes this code is good, it's only technical improvement.

Actual Result:(*)

Expected Result:(*)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Component: AutoloadFixed in 2.4.xThe issue has been fixed in 2.4-develop branchIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentPriority: P3May be fixed according to the position in the backlog.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchSeverity: S3Affects non-critical data or functionality and does not force users to employ a workaround.Triage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject it

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions