Closed
Description
This issue is automatically created based on existing pull request: #27077: Update FlushCacheByTags to use after plugins instead of around plugins
Description (*)
This PR contains a few small quality of life improvements to the FlushCacheByTags class:
- Conversion of around plugins to after plugins.
These original plugins were created when after plugins did not contain the arguments to the original call. Now that they do, we can move to after plugins and not affect the call stack - Micro-optimization in cleanCacheByTags.
Calling array_unique in a loop, for the same variable isn't great. This change now caches it in a local variable. - Updating doc-blocks.
Newer documentation standards request the exclusion of parameters and return types that are duplicative in nature. I've also updated the small descriptions to read better
Preconditions (*)
- Magento 2.4-develop
Steps to reproduce (*)
- Perform step debugging in Plugin before/after changes and compare that tags are the same during the following scenarios:
- Product Creation
- Production Deletion
Expected result (*)
The tags are the same
Actual result (*)
The tags are differant
Contribution checklist (*)
- Pull request has a meaningful description of its purpose
- All commits are accompanied by meaningful commit messages
- All new or changed code is covered with unit/integration tests (if applicable)
- All automated tests passed successfully (all builds are green)
Metadata
Metadata
Assignees
Labels
The issue has been fixed in 2.4-develop branchGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 1 Passed. Automatic verification of issue format passedGate 4. Acknowledged. Issue is added to backlog and ready for developmentMay be fixed according to the position in the backlog.Indicates original Magento version for the Issue report.The issue has been reproduced on latest 2.4-develop branchAffects non-critical data or functionality and does not force users to employ a workaround.
Type
Projects
Status
Done